peachisai commented on code in PR #11819:
URL: https://github.com/apache/skywalking/pull/11819#discussion_r1463261313
##########
.github/workflows/skywalking.yaml:
##########
@@ -583,16 +583,21 @@ jobs:
config: test/e2e-v2/cases/vm/zabbix/e2e.yaml
- name: VM Prometheus
config: test/e2e-v2/cases/vm/prometheus-node-exporter/e2e.yaml
+ env: OTEL_COLLECTOR_VERSION=0.92.0
- name: VM Telegraf
config: test/e2e-v2/cases/vm/telegraf/e2e.yaml
- name: So11y
config: test/e2e-v2/cases/so11y/e2e.yaml
+ env: OTEL_COLLECTOR_VERSION=0.92.0
- name: MySQL Prometheus and slowsql
config: test/e2e-v2/cases/mysql/mysql-slowsql/e2e.yaml
+ env: OTEL_COLLECTOR_VERSION=0.92.0
Review Comment:
> This could be on matrix level?
I will set this as a global env variable with matrix level If we do not need
assign values individually for each test.
##########
.github/workflows/skywalking.yaml:
##########
@@ -583,16 +583,21 @@ jobs:
config: test/e2e-v2/cases/vm/zabbix/e2e.yaml
- name: VM Prometheus
config: test/e2e-v2/cases/vm/prometheus-node-exporter/e2e.yaml
+ env: OTEL_COLLECTOR_VERSION=0.92.0
- name: VM Telegraf
config: test/e2e-v2/cases/vm/telegraf/e2e.yaml
- name: So11y
config: test/e2e-v2/cases/so11y/e2e.yaml
+ env: OTEL_COLLECTOR_VERSION=0.92.0
- name: MySQL Prometheus and slowsql
config: test/e2e-v2/cases/mysql/mysql-slowsql/e2e.yaml
+ env: OTEL_COLLECTOR_VERSION=0.92.0
Review Comment:
> This could be on matrix level?
I will set this as a global env variable with matrix level If we do not need
assign values individually for each test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
