wu-sheng commented on a change in pull request #3437: Add TTL E2E test URL: https://github.com/apache/skywalking/pull/3437#discussion_r322024290
########## File path: test/e2e/e2e-ttl/e2e-ttl-es/src/test/java/org/apache/skywalking/e2e/StorageTTLITCase.java ########## @@ -0,0 +1,278 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.skywalking.e2e; + +import lombok.extern.slf4j.Slf4j; +import org.apache.skywalking.apm.dependencies.io.grpc.ManagedChannel; +import org.apache.skywalking.apm.dependencies.io.grpc.ManagedChannelBuilder; +import org.apache.skywalking.apm.dependencies.io.grpc.internal.DnsNameResolverProvider; +import org.apache.skywalking.apm.dependencies.io.grpc.netty.NettyChannelBuilder; +import org.apache.skywalking.apm.dependencies.io.grpc.stub.StreamObserver; +import org.apache.skywalking.apm.network.common.DetectPoint; +import org.apache.skywalking.apm.network.servicemesh.MeshProbeDownstream; +import org.apache.skywalking.apm.network.servicemesh.Protocol; +import org.apache.skywalking.apm.network.servicemesh.ServiceMeshMetric; +import org.apache.skywalking.apm.network.servicemesh.ServiceMeshMetricServiceGrpc; +import org.apache.skywalking.e2e.metrics.AllOfMetricsMatcher; +import org.apache.skywalking.e2e.metrics.AtLeastOneOfMetricsMatcher; +import org.apache.skywalking.e2e.metrics.Metrics; +import org.apache.skywalking.e2e.metrics.MetricsQuery; +import org.apache.skywalking.e2e.metrics.MetricsValueMatcher; +import org.apache.skywalking.e2e.service.Service; +import org.apache.skywalking.e2e.service.ServicesQuery; +import org.junit.Before; +import org.junit.Test; + +import java.time.LocalDateTime; +import java.time.ZoneOffset; +import java.util.List; +import java.util.concurrent.CountDownLatch; + +import static org.apache.skywalking.e2e.metrics.MetricsQuery.SERVICE_P99; +import static org.assertj.core.api.Assertions.assertThat; + +/** + * @author kezhenxu94 + */ +@Slf4j +public class StorageTTLITCase { + private static final int SW_STORAGE_ES_MONTH_METRIC_DATA_TTL = 4; + private static final int SW_STORAGE_ES_OTHER_METRIC_DATA_TTL = 5; + + private static final int MAX_INBOUND_MESSAGE_SIZE = 1024 * 1024 * 50; + private static final boolean USE_PLAIN_TEXT = true; + private static final boolean SUCCESS = true; + + private SimpleQueryClient queryClient; + + private ServiceMeshMetricServiceGrpc.ServiceMeshMetricServiceStub grpcStub; + + @Before + public void setUp() { + + final String swWebappHost = System.getProperty("sw.webapp.host", "127.0.0.1"); + final String swWebappPort = System.getProperty("sw.webapp.port", "32789"); + final String oapPort = System.getProperty("oap.port", "32788"); + queryClient = new SimpleQueryClient(swWebappHost, swWebappPort); + + final ManagedChannelBuilder builder = + NettyChannelBuilder.forAddress("127.0.0.1", Integer.parseInt(oapPort)) + .nameResolverFactory(new DnsNameResolverProvider()) + .maxInboundMessageSize(MAX_INBOUND_MESSAGE_SIZE) + .usePlaintext(USE_PLAIN_TEXT); + + final ManagedChannel channel = builder.build(); + + grpcStub = ServiceMeshMetricServiceGrpc.newStub(channel); + } + + @Test(timeout = 360000) + public void dayMetricsDataShouldBeRemovedAfterTTL() throws Exception { + + final ServiceMeshMetric.Builder builder = ServiceMeshMetric + .newBuilder() + .setSourceServiceName("e2e-test-source-service") + .setSourceServiceInstance("e2e-test-source-service-instance") + .setDestServiceName("e2e-test-dest-service") + .setDestServiceInstance("e2e-test-dest-service-instance") + .setEndpoint("e2e/test") + .setLatency(2000) + .setResponseCode(200) + .setStatus(SUCCESS) + .setProtocol(Protocol.HTTP) + .setDetectPoint(DetectPoint.server); + + final LocalDateTime now = LocalDateTime.now(); + final LocalDateTime startTime = now.minusDays(SW_STORAGE_ES_OTHER_METRIC_DATA_TTL + 1); + final LocalDateTime endTime = startTime.plusMinutes(1); + + final LocalDateTime queryStart = startTime; + final LocalDateTime queryEnd = now.minusDays(SW_STORAGE_ES_OTHER_METRIC_DATA_TTL); + + ensureSendingMetricsWorks( + builder, + startTime.toEpochSecond(ZoneOffset.UTC) * 1000, + endTime.toEpochSecond(ZoneOffset.UTC) * 1000, + queryStart, + queryEnd, + "DAY" + ); + + shouldBeEmptyBetweenTimeRange(queryStart, queryEnd, "DAY"); + } + + @Test(timeout = 360000) + public void monthMetricsDataShouldBeRemovedAfterTTL() throws Exception { + + final ServiceMeshMetric.Builder builder = ServiceMeshMetric + .newBuilder() + .setSourceServiceName("e2e-test-source-service") + .setSourceServiceInstance("e2e-test-source-service-instance") + .setDestServiceName("e2e-test-dest-service") + .setDestServiceInstance("e2e-test-dest-service-instance") + .setEndpoint("e2e/test") + .setLatency(2000) + .setResponseCode(200) + .setStatus(SUCCESS) + .setProtocol(Protocol.HTTP) + .setDetectPoint(DetectPoint.server); + + final LocalDateTime now = LocalDateTime.now(); + final LocalDateTime startTime = now.minusMonths(SW_STORAGE_ES_MONTH_METRIC_DATA_TTL + 1); + final LocalDateTime endTime = startTime.plusMinutes(1); + + final LocalDateTime queryStart = startTime; + final LocalDateTime queryEnd = now.minusMonths(SW_STORAGE_ES_MONTH_METRIC_DATA_TTL); + + ensureSendingMetricsWorks( + builder, + startTime.toEpochSecond(ZoneOffset.UTC) * 1000, + endTime.toEpochSecond(ZoneOffset.UTC) * 1000, + queryStart, + queryEnd, + "MONTH" + ); + + shouldBeEmptyBetweenTimeRange(queryStart, queryEnd, "MONTH"); + } + + private void shouldBeEmptyBetweenTimeRange( + final LocalDateTime queryStart, + final LocalDateTime queryEnd, + final String step + ) throws InterruptedException { + + boolean valid = false; + while (!valid) { + try { + final Metrics serviceMetrics = queryMetrics(queryStart, queryEnd, step); + + log.info("ServiceMetrics: {}", serviceMetrics); + + AllOfMetricsMatcher instanceRespTimeMatcher = new AllOfMetricsMatcher(); + MetricsValueMatcher equalsZero = new MetricsValueMatcher(); + equalsZero.setValue("eq 0"); + instanceRespTimeMatcher.setValue(equalsZero); + try { + instanceRespTimeMatcher.verify(serviceMetrics); + valid = true; + } catch (Throwable t) { + log.warn("History metrics data are not deleted yet, {}", t.getMessage()); + Thread.sleep(10000); + } + } catch (Throwable t) { + log.warn("History metrics data are not deleted yet", t); + Thread.sleep(10000); Review comment: I think it is more reasonable to set max test times, according to your `SW_CORE_DATA_KEEPER_EXECUTE_PERIOD` has been set to 1(min). Then, I would say 10 times(10 mins) should be good to say success or failure? What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
