wu-sheng commented on PR #679: URL: https://github.com/apache/skywalking-java/pull/679#issuecomment-2047512936
> Of course, this is possible. > But before that, I also have a question. I searched for the code of skywalking-java and found that only the druid plugin has attributes called poolingCount and idleCount. Do we need to change the original meaning of the druid for these two attributes in APM, perhaps we need a standardized semantic convention? Good question. It should be good to remove that, rather than recalculate. __ Meanwhile, to make CI passed, you should fix the expected file. https://github.com/apache/skywalking-java/blob/eb1041675cafb31dcc8da1fc0a45bc796d5b912c/test/plugin/scenarios/druid-1.x-scenario/config/expectedData.yaml#L223-L227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
