This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch chore
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 147c3cbf44890d2116ee9eff9d4bc9e6d34bf12f
Author: Wu Sheng <wu.sh...@foxmail.com>
AuthorDate: Fri Apr 12 09:08:24 2024 +0800
Remove `kafka-fetcher/default/createTopicIfNotExist`
---
docs/en/changes/changes.md | 1 +
docs/en/setup/backend/configuration-vocabulary.md | 1 -
.../oap/server/analyzer/agent/kafka/module/KafkaFetcherConfig.java | 5 -----
3 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index 2cd81f4aea..e6cb16b541 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -97,6 +97,7 @@
* Fix `NullPointerException` in Istio ServiceEntry registry.
* Remove unnecessary `componentIds` as series ID in the
`ServiceRelationClientSideMetrics` and `ServiceRelationServerSideMetrics`
entities.
* Fix not throw error when part of expression not matched any expression node
in the `MQE` and `PromQL.
+* Remove `kafka-fetcher/default/createTopicIfNotExist` as the creation is
automatically since [#7326](https://github.com/apache/skywalking/issues/7326)
(v8.7.0).
#### UI
diff --git a/docs/en/setup/backend/configuration-vocabulary.md
b/docs/en/setup/backend/configuration-vocabulary.md
index 4dd361ffb1..2d843308d6 100644
--- a/docs/en/setup/backend/configuration-vocabulary.md
+++ b/docs/en/setup/backend/configuration-vocabulary.md
@@ -225,7 +225,6 @@ The Configuration Vocabulary lists all available
configurations provided by `app
| - | - | bootstrapServers
| A list of host/port
pairs to use for establishing the initial connection to the Kafka cluster.
[...]
| - | - | namespace
| Namespace aims to
isolate multi OAP cluster when using the same Kafka cluster. If you set a
namespace for Kafka fetcher, OAP will add a prefix to topic name. You should
also set namespace in `agent.config`. The property is named
`plugin.kafka.namespace`. [...]
| - | - | groupId
| A unique string that
identifies the consumer group to which this consumer belongs.
[...]
-| - | - | createTopicIfNotExist
| If true, this creates
Kafka topic (if it does not already exist).
[...]
| - | - | partitions
| The number of
partitions for the topic being created.
[...]
| - | - | consumers
| The number of consumers
to create.
[...]
| - | - | enableNativeProtoLog
| Enables fetching and
handling native proto log data.
[...]
diff --git
a/oap-server/server-fetcher-plugin/kafka-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/analyzer/agent/kafka/module/KafkaFetcherConfig.java
b/oap-server/server-fetcher-plugin/kafka-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/analyzer/agent/kafka/module/KafkaFetcherConfig.java
index 40ced70c4b..f0d6ae2c43 100644
---
a/oap-server/server-fetcher-plugin/kafka-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/analyzer/agent/kafka/module/KafkaFetcherConfig.java
+++
b/oap-server/server-fetcher-plugin/kafka-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/analyzer/agent/kafka/module/KafkaFetcherConfig.java
@@ -42,11 +42,6 @@ public class KafkaFetcherConfig extends ModuleConfig {
*/
private String groupId = "skywalking-consumer";
- /**
- * If true, create the Kafka topic when it does not exist.
- */
- private boolean createTopicIfNotExist = true;
-
/**
* The number of partitions for the topic being created.
*/
