fgksgf commented on code in PR #113: URL: https://github.com/apache/skywalking-swck/pull/113#discussion_r1563892941
########## operator/apis/operator/v1alpha1/eventexporter_types.go: ########## @@ -0,0 +1,78 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package v1alpha1 + +import ( + appsv1 "k8s.io/api/apps/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" +) + +// EventExporterSpec defines the desired state of EventExporter +type EventExporterSpec struct { + // Version of EventExporter. + // +kubebuilder:validation:Required + Version string `json:"version,omitempty"` + // Image is the event exporter Docker image to deploy. + Image string `json:"image,omitempty"` + // Instances is the number of event exporter pods + // +kubebuilder:validation:Required + Instances int32 `json:"instances,omitempty"` Review Comment: `Replicas` would be better ########## operator/controllers/operator/eventexporter_controller.go: ########## @@ -0,0 +1,210 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package operator + +import ( + "context" + "fmt" + "github.com/go-logr/logr" + l "github.com/sirupsen/logrus" + apps "k8s.io/api/apps/v1" + core "k8s.io/api/core/v1" + apiequal "k8s.io/apimachinery/pkg/api/equality" + apierrors "k8s.io/apimachinery/pkg/api/errors" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "k8s.io/apimachinery/pkg/runtime" + "k8s.io/client-go/tools/record" + "k8s.io/client-go/util/retry" + ctrl "sigs.k8s.io/controller-runtime" + "sigs.k8s.io/controller-runtime/pkg/client" + runtimelog "sigs.k8s.io/controller-runtime/pkg/log" + "text/template" + + operatorv1alpha1 "github.com/apache/skywalking-swck/operator/apis/operator/v1alpha1" + "github.com/apache/skywalking-swck/operator/pkg/kubernetes" +) + +// EventExporterReconciler reconciles a EventExporter object +type EventExporterReconciler struct { + client.Client + Scheme *runtime.Scheme + FileRepo kubernetes.Repo + Recorder record.EventRecorder +} + +// +kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=eventexporters,verbs=get;list;watch;create;update;patch;delete +// +kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=eventexporters/status,verbs=get;update;patch +// +kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=eventexporters/finalizers,verbs=update +// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete +// +kubebuilder:rbac:groups="",resources=configmaps,verbs=get;list +// +kubebuilder:rbac:groups="",resources=events,verbs=create;patch + +func (r *EventExporterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { + log := runtimelog.FromContext(ctx) + log.Info("=====================eventexporter reconcile started================================") + + eventExporter := operatorv1alpha1.EventExporter{} + if err := r.Client.Get(ctx, req.NamespacedName, &eventExporter); err != nil { + return ctrl.Result{}, client.IgnoreNotFound(err) + } + + if _, err := r.overlayData(ctx, log, &eventExporter); err != nil { + l.Error(err, "failed to overlay eventexporter's configMap") + return ctrl.Result{}, err + } + + ff, err := r.FileRepo.GetFilesRecursive("templates") + if err != nil { + log.Error(err, "failed to load resource templates") + return ctrl.Result{}, err + } + + app := kubernetes.Application{ + Client: r.Client, + FileRepo: r.FileRepo, + CR: &eventExporter, + GVK: operatorv1alpha1.GroupVersion.WithKind("EventExporter"), + Recorder: r.Recorder, + TmplFunc: template.FuncMap{ + "md5Data": func() string { return MD5Hash(eventExporter.Spec.Data) }, + }, + } + + if err := app.ApplyAll(ctx, ff, log); err != nil { + return ctrl.Result{}, err + } + + if err := r.checkState(ctx, log, &eventExporter); err != nil { + l.Error(err, "failed to check sub resources state") + return ctrl.Result{}, err + } + + return ctrl.Result{RequeueAfter: schedDuration}, nil + +} + +func (r *EventExporterReconciler) overlayData(ctx context.Context, log logr.Logger, eventExporter *operatorv1alpha1.EventExporter) (bool, error) { + + configmap := core.ConfigMap{} + err := r.Client.Get(ctx, client.ObjectKey{Namespace: eventExporter.Namespace, Name: eventExporter.Name}, &configmap) + if err != nil && !apierrors.IsNotFound(err) { + log.Error(err, "failed to get the eventexporter's configmap") + return false, err + } + + newMd5 := MD5Hash(eventExporter.Spec.Data) + oldMd5 := MD5Hash("") + if !apierrors.IsNotFound(err) { + oldMd5 = configmap.Labels["md5-data"] + } + + if newMd5 == oldMd5 { + log.Info("eventexporter configuration keeps the same as before") + return false, nil + } + + if !apierrors.IsNotFound(err) { + if err := r.Client.Delete(ctx, &configmap); err != nil { + log.Error(err, "failed to delete eventexporter's configmap") + return true, nil + } + } + + configmap = core.ConfigMap{ + ObjectMeta: metav1.ObjectMeta{ + Name: eventExporter.Name, + Namespace: eventExporter.Namespace, + OwnerReferences: []metav1.OwnerReference{ + { + APIVersion: eventExporter.APIVersion, + Kind: eventExporter.Kind, + Name: eventExporter.Name, + UID: eventExporter.UID, + }, + }, + Labels: map[string]string{ + "version": eventExporter.Spec.Version, + "md5-data": newMd5, + }, + }, + Data: map[string]string{"config.yaml": eventExporter.Spec.Data}, + } + + if err := r.Client.Create(ctx, &configmap); err != nil { + log.Error(err, "failed to create eventexporter's configmap") + return true, err + } + + return true, nil +} + +func (r *EventExporterReconciler) checkState(ctx context.Context, log logr.Logger, eventExporter *operatorv1alpha1.EventExporter) error { + overlay := operatorv1alpha1.EventExporterStatus{} + deployment := apps.Deployment{} + errCol := new(kubernetes.ErrorCollector) + + if err := r.Client.Get(ctx, client.ObjectKey{Namespace: eventExporter.Namespace, Name: eventExporter.Name + "-eventexporter"}, &deployment); err != nil && !apierrors.IsNotFound(err) { + errCol.Collect(fmt.Errorf("failed to get deployment: %w", err)) + } else { + overlay.Conditions = deployment.Status.Conditions + overlay.AvailableReplicas = deployment.Status.AvailableReplicas + } + + if apiequal.Semantic.DeepDerivative(overlay, eventExporter.Status) { + log.Info("Status keeps the same as before") + return errCol.Error() + } + + if err := r.updateStatus(ctx, eventExporter, overlay, errCol); err != nil { + errCol.Collect(fmt.Errorf("failed to update status of EventExporter: %w", err)) + } + + log.Info("updated Status sub resource") + + return errCol.Error() +} + +func (r *EventExporterReconciler) updateStatus(ctx context.Context, eventExporter *operatorv1alpha1.EventExporter, + overlay operatorv1alpha1.EventExporterStatus, errCol *kubernetes.ErrorCollector) error { + // avoid resource conflict + return retry.RetryOnConflict(retry.DefaultBackoff, func() error { + if err := r.Client.Get(ctx, client.ObjectKey{Name: eventExporter.Name, Namespace: eventExporter.Namespace}, eventExporter); err != nil { + errCol.Collect(fmt.Errorf("failed to get EventExporter: %w", err)) + } + + eventExporter.Status = overlay + eventExporter.Kind = "EventExporter" + if err := kubernetes.ApplyOverlay(eventExporter, &operatorv1alpha1.EventExporter{Status: overlay}); err != nil { + errCol.Collect(fmt.Errorf("failed to apply overlay: %w", err)) + } + + if err := r.Status().Update(ctx, eventExporter); err != nil { + errCol.Collect(fmt.Errorf("failed to update status of EventExporter: %w", err)) + } + return errCol.Error() + }) +} + +// SetupWithManager sets up the controller with the Manager. +func (r *EventExporterReconciler) SetupWithManager(mgr ctrl.Manager) error { + return ctrl.NewControllerManagedBy(mgr). + For(&operatorv1alpha1.EventExporter{}). + Owns(&apps.Deployment{}). + Owns(&core.ConfigMap{}). Review Comment: I think if we do not add predicates, all deploy/configmaps change will trigger eventExporter controller to reconcile. So we can remove them. ########## operator/controllers/operator/eventexporter_controller.go: ########## @@ -0,0 +1,210 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package operator + +import ( + "context" + "fmt" + "github.com/go-logr/logr" + l "github.com/sirupsen/logrus" + apps "k8s.io/api/apps/v1" + core "k8s.io/api/core/v1" + apiequal "k8s.io/apimachinery/pkg/api/equality" + apierrors "k8s.io/apimachinery/pkg/api/errors" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "k8s.io/apimachinery/pkg/runtime" + "k8s.io/client-go/tools/record" + "k8s.io/client-go/util/retry" + ctrl "sigs.k8s.io/controller-runtime" + "sigs.k8s.io/controller-runtime/pkg/client" + runtimelog "sigs.k8s.io/controller-runtime/pkg/log" + "text/template" + + operatorv1alpha1 "github.com/apache/skywalking-swck/operator/apis/operator/v1alpha1" + "github.com/apache/skywalking-swck/operator/pkg/kubernetes" +) + +// EventExporterReconciler reconciles a EventExporter object +type EventExporterReconciler struct { + client.Client + Scheme *runtime.Scheme + FileRepo kubernetes.Repo + Recorder record.EventRecorder +} + +// +kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=eventexporters,verbs=get;list;watch;create;update;patch;delete +// +kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=eventexporters/status,verbs=get;update;patch +// +kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=eventexporters/finalizers,verbs=update +// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete +// +kubebuilder:rbac:groups="",resources=configmaps,verbs=get;list +// +kubebuilder:rbac:groups="",resources=events,verbs=create;patch + +func (r *EventExporterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { + log := runtimelog.FromContext(ctx) + log.Info("=====================eventexporter reconcile started================================") Review Comment: Let's also log the req.name and req.namespace ########## operator/apis/operator/v1alpha1/eventexporter_webhook.go: ########## @@ -0,0 +1,91 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package v1alpha1 + +import ( + "fmt" + "k8s.io/apimachinery/pkg/runtime" + ctrl "sigs.k8s.io/controller-runtime" + logf "sigs.k8s.io/controller-runtime/pkg/log" + "sigs.k8s.io/controller-runtime/pkg/webhook" + "sigs.k8s.io/controller-runtime/pkg/webhook/admission" +) + +// log is for logging in this package. +var eventexporterlog = logf.Log.WithName("eventexporter-resource") + +func (r *EventExporter) SetupWebhookWithManager(mgr ctrl.Manager) error { + return ctrl.NewWebhookManagedBy(mgr). + For(r). + Complete() +} + +//+kubebuilder:webhook:path=/mutate-operator-skywalking-apache-org-v1alpha1-eventexporter,mutating=true,failurePolicy=fail,sideEffects=None,groups=operator.skywalking.apache.org,resources=eventexporters,verbs=create;update,versions=v1alpha1,name=meventexporter.kb.io,admissionReviewVersions=v1 + +var _ webhook.Defaulter = &EventExporter{} + +// Default implements webhook.Defaulter so a webhook will be registered for the type +func (r *EventExporter) Default() { + eventexporterlog.Info("default", "name", r.Name) + + if r.Spec.Version == "" { + // use the latest version by default + r.Spec.Version = "latest" + } + + if r.Spec.Image == "" { + r.Spec.Image = fmt.Sprintf("apache/skywalking-kubernetes-event-exporter:%s", r.Spec.Version) Review Comment: Ditto. ########## operator/apis/operator/v1alpha1/eventexporter_types.go: ########## @@ -0,0 +1,78 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package v1alpha1 + +import ( + appsv1 "k8s.io/api/apps/v1" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" +) + +// EventExporterSpec defines the desired state of EventExporter +type EventExporterSpec struct { + // Version of EventExporter. + // +kubebuilder:validation:Required + Version string `json:"version,omitempty"` + // Image is the event exporter Docker image to deploy. + Image string `json:"image,omitempty"` + // Instances is the number of event exporter pods + // +kubebuilder:validation:Required + Instances int32 `json:"instances,omitempty"` + // Data of filters and exporters + // +kubebuilder:validation:Optional + Data string `json:"data,omitempty"` Review Comment: How about renaming it to `Config` ########## operator/controllers/operator/eventexporter_controller.go: ########## @@ -0,0 +1,210 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package operator + +import ( + "context" + "fmt" + "github.com/go-logr/logr" + l "github.com/sirupsen/logrus" + apps "k8s.io/api/apps/v1" + core "k8s.io/api/core/v1" + apiequal "k8s.io/apimachinery/pkg/api/equality" + apierrors "k8s.io/apimachinery/pkg/api/errors" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "k8s.io/apimachinery/pkg/runtime" + "k8s.io/client-go/tools/record" + "k8s.io/client-go/util/retry" + ctrl "sigs.k8s.io/controller-runtime" + "sigs.k8s.io/controller-runtime/pkg/client" + runtimelog "sigs.k8s.io/controller-runtime/pkg/log" + "text/template" + + operatorv1alpha1 "github.com/apache/skywalking-swck/operator/apis/operator/v1alpha1" + "github.com/apache/skywalking-swck/operator/pkg/kubernetes" +) + +// EventExporterReconciler reconciles a EventExporter object +type EventExporterReconciler struct { + client.Client + Scheme *runtime.Scheme + FileRepo kubernetes.Repo + Recorder record.EventRecorder +} + +// +kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=eventexporters,verbs=get;list;watch;create;update;patch;delete +// +kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=eventexporters/status,verbs=get;update;patch +// +kubebuilder:rbac:groups=operator.skywalking.apache.org,resources=eventexporters/finalizers,verbs=update +// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete +// +kubebuilder:rbac:groups="",resources=configmaps,verbs=get;list +// +kubebuilder:rbac:groups="",resources=events,verbs=create;patch + +func (r *EventExporterReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { + log := runtimelog.FromContext(ctx) + log.Info("=====================eventexporter reconcile started================================") + + eventExporter := operatorv1alpha1.EventExporter{} + if err := r.Client.Get(ctx, req.NamespacedName, &eventExporter); err != nil { + return ctrl.Result{}, client.IgnoreNotFound(err) + } + + if _, err := r.overlayData(ctx, log, &eventExporter); err != nil { + l.Error(err, "failed to overlay eventexporter's configMap") + return ctrl.Result{}, err + } + + ff, err := r.FileRepo.GetFilesRecursive("templates") + if err != nil { + log.Error(err, "failed to load resource templates") + return ctrl.Result{}, err + } + + app := kubernetes.Application{ + Client: r.Client, + FileRepo: r.FileRepo, + CR: &eventExporter, + GVK: operatorv1alpha1.GroupVersion.WithKind("EventExporter"), + Recorder: r.Recorder, + TmplFunc: template.FuncMap{ + "md5Data": func() string { return MD5Hash(eventExporter.Spec.Data) }, + }, + } + + if err := app.ApplyAll(ctx, ff, log); err != nil { + return ctrl.Result{}, err + } + + if err := r.checkState(ctx, log, &eventExporter); err != nil { + l.Error(err, "failed to check sub resources state") + return ctrl.Result{}, err + } + + return ctrl.Result{RequeueAfter: schedDuration}, nil + +} + +func (r *EventExporterReconciler) overlayData(ctx context.Context, log logr.Logger, eventExporter *operatorv1alpha1.EventExporter) (bool, error) { Review Comment: Let's give the returned variables names, like `(changed bool, err error)` for better readability ########## operator/controllers/operator/eventexporter_controller.go: ########## @@ -0,0 +1,210 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package operator + +import ( + "context" + "fmt" + "github.com/go-logr/logr" + l "github.com/sirupsen/logrus" + apps "k8s.io/api/apps/v1" + core "k8s.io/api/core/v1" + apiequal "k8s.io/apimachinery/pkg/api/equality" + apierrors "k8s.io/apimachinery/pkg/api/errors" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "k8s.io/apimachinery/pkg/runtime" + "k8s.io/client-go/tools/record" + "k8s.io/client-go/util/retry" + ctrl "sigs.k8s.io/controller-runtime" + "sigs.k8s.io/controller-runtime/pkg/client" + runtimelog "sigs.k8s.io/controller-runtime/pkg/log" + "text/template" Review Comment: sort the imports, otherwise lint will fail ########## operator/apis/operator/v1alpha1/eventexporter_webhook.go: ########## @@ -0,0 +1,91 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package v1alpha1 + +import ( + "fmt" + "k8s.io/apimachinery/pkg/runtime" + ctrl "sigs.k8s.io/controller-runtime" + logf "sigs.k8s.io/controller-runtime/pkg/log" + "sigs.k8s.io/controller-runtime/pkg/webhook" + "sigs.k8s.io/controller-runtime/pkg/webhook/admission" +) + +// log is for logging in this package. +var eventexporterlog = logf.Log.WithName("eventexporter-resource") + +func (r *EventExporter) SetupWebhookWithManager(mgr ctrl.Manager) error { + return ctrl.NewWebhookManagedBy(mgr). + For(r). + Complete() +} + +//+kubebuilder:webhook:path=/mutate-operator-skywalking-apache-org-v1alpha1-eventexporter,mutating=true,failurePolicy=fail,sideEffects=None,groups=operator.skywalking.apache.org,resources=eventexporters,verbs=create;update,versions=v1alpha1,name=meventexporter.kb.io,admissionReviewVersions=v1 + +var _ webhook.Defaulter = &EventExporter{} + +// Default implements webhook.Defaulter so a webhook will be registered for the type +func (r *EventExporter) Default() { + eventexporterlog.Info("default", "name", r.Name) + + if r.Spec.Version == "" { + // use the latest version by default + r.Spec.Version = "latest" Review Comment: Let's use a constant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
