RCQE-bot commented on PR #113: URL: https://github.com/apache/skywalking-swck/pull/113#issuecomment-2054621462
## RCQE-bot: Commit Quality Assessment 🔎 I've carefully evaluated the recent commits, and here's the current state of the commit quality: ### Metrics 📊 - Previous Commits: diff hunk in file [operator/apis/operator/v1alpha1/eventexporter_types.go](https://github.com/apache/skywalking-swck/pull/113/files/d41f3c75f77368d7468ca3a8816c69ec59f44b55#diff-08e64e4e9e02c8371bf5173ecd944aa820a586af513d2c88a37680f117958919) in commit [ed272283fa32a6b960f8fbc9b5ce1a45f4ddf63d](https://github.com/apache/skywalking-swck/pull/113/commits/ed272283fa32a6b960f8fbc9b5ce1a45f4ddf63d) - Code Review: I think if we do not add predicates, all deploy/configmaps change will trigger eventExporter controller to reconcile. So we can remove them. ### Suggestions 💡 - Need Review Again 🚫 : The commits do not currently meet the quality standards. I recommend not merging them into the main branch until the above suggestions have been implemented and a subsequent review confirms the quality. Please address the points mentioned and submit the commits for another round of review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
