wankai123 commented on code in PR #12130:
URL: https://github.com/apache/skywalking/pull/12130#discussion_r1571969402
##########
oap-server/server-starter/src/main/resources/otel-rules/mysql/mysql-service.yaml:
##########
@@ -59,8 +59,10 @@ metricsRules:
## connect
- name: connects_aborted
exp: mysql_global_status_aborted_connects
- - name: connects_available
- exp: mysql_global_variables_max_connections.sum(['host_name']) -
mysql_global_status_threads_connected.sum(['host_name'])
+ - name: max_connections
+ exp:
mysql_global_variables_max_connections.sum(['host_name','service_instance_id'])
+ - name: status_thread_connected
+ exp:
mysql_global_status_threads_connected.sum(['host_name','service_instance_id'])
- name: connection_errors_max_connections
exp:
mysql_global_status_connection_errors_total.tagEqual('error','max_connection')
Review Comment:
Why do some of the metrics do not require `service_instance_id` ? They are
not instance level metrics?
##########
oap-server/server-starter/src/main/resources/otel-rules/mysql/mysql-service.yaml:
##########
@@ -59,8 +59,10 @@ metricsRules:
## connect
- name: connects_aborted
exp: mysql_global_status_aborted_connects
- - name: connects_available
- exp: mysql_global_variables_max_connections.sum(['host_name']) -
mysql_global_status_threads_connected.sum(['host_name'])
+ - name: max_connections
+ exp:
mysql_global_variables_max_connections.sum(['host_name','service_instance_id'])
+ - name: status_thread_connected
+ exp:
mysql_global_status_threads_connected.sum(['host_name','service_instance_id'])
- name: connection_errors_max_connections
exp:
mysql_global_status_connection_errors_total.tagEqual('error','max_connection')
Review Comment:
Why some of the metrics do not require `service_instance_id` ? They are not
instance level metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
