Superskyyy commented on code in PR #12321:
URL: https://github.com/apache/skywalking/pull/12321#discussion_r1634647351


##########
docs/en/setup/backend/configuration-vocabulary.md:
##########
@@ -38,7 +38,7 @@ The Configuration Vocabulary lists all available 
configurations provided by `app
 | -                       | -             | autocompleteTagValuesQueryMaxSize  
                                                                                
                                                      | The max size of tags 
values for autocomplete select.                                                 
                                                                                
                                                                                
                                                                                
                                                                                
                                      | 
SW_AUTOCOMPLETE_TAG_VALUES_QUERY_MAX_SIZE             | 100                     
                                                                     |
 | -                       | -             | gRPCThreadPoolSize                 
                                                                                
                                                      | Pool size of gRPC 
server.                                                                         
                                                                                
                                                                                
                                                                                
                                                                                
                                         | SW_CORE_GRPC_THREAD_POOL_SIZE        
                 | Default to gRPC's implementation, which is a cached thread 
pool that can grow infinitely.    |
 | -                       | -             | maxConcurrentCallsPerConnection    
                                                                                
                                                      | The maximum number of 
concurrent calls permitted for each incoming connection. Defaults to no limit.  
                                                                                
                                                                                
                                                                                
                                                                                
                                     | SW_CORE_GRPC_MAX_CONCURRENT_CALL         
             | -                                                                
                            |
-| -                       | -             | maxMessageSize                     
                                                                                
                                                      | Sets the maximum 
message size allowed to be received on the server. Empty means 4 MiB.           
                                                                                
                                                                                
                                                                                
                                                                                
                                          | SW_CORE_GRPC_MAX_MESSAGE_SIZE       
                  | 4M(based on Netty)                                          
                                 |
+| -                       | -             | maxMessageSize                     
                                                                                
                                                      | Sets the maximum 
message size allowed to be received on the server. Empty means 4 MiB.           
                                                                                
                                                                                
                                                                                
                                                                                
                                          | SW_CORE_GRPC_MAX_MESSAGE_SIZE       
                  | 52428800 (50MB)                                             
                                 |

Review Comment:
   Default means 50MB?



##########
docs/en/setup/backend/configuration-vocabulary.md:
##########
@@ -171,6 +171,7 @@ The Configuration Vocabulary lists all available 
configurations provided by `app
 | -                       | -             | gRPCSslKeyPath                     
                                                                                
                                                      | File path of gRPC SSL 
key.                                                                            
                                                                                
                                                                                
                                                                                
                                                                                
                                     | SW_RECEIVER_GRPC_SSL_KEY_PATH            
             | -                                                                
                            |
 | -                       | -             | gRPCSslCertChainPath               
                                                                                
                                                      | File path of gRPC SSL 
cert chain.                                                                     
                                                                                
                                                                                
                                                                                
                                                                                
                                     | SW_RECEIVER_GRPC_SSL_CERT_CHAIN_PATH     
             | -                                                                
                            |
 | -                       | -             | maxConcurrentCallsPerConnection    
                                                                                
                                                      | The maximum number of 
concurrent calls permitted for each incoming connection. Defaults to no limit.  
                                                                                
                                                                                
                                                                                
                                                                                
                                     | SW_RECEIVER_GRPC_MAX_CONCURRENT_CALL     
             | -                                                                
                            |
+| -                       | -             | maxMessageSize                     
                                                                                
                                                      | Sets the maximum 
message size allowed to be received on the server. Empty means 4 MiB.           
                                                                                
                                                                                
                                                                                
                                                                                
                                          | SW_RECEIVER_GRPC_MAX_MESSAGE_SIZE   
                  | 52428800 (50MB)                                             
                                 |

Review Comment:
   Same as above. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to