lujiajing1126 commented on PR #704: URL: https://github.com/apache/skywalking-java/pull/704#issuecomment-2222211350
> All of your discussions have been very professional, @lujiajing1126. From the actual situation I've encountered (we upgraded to JDK 17 and found this to be the case with more than 10 services), I don't want the system we provide to rely on users‘ exact correct usage. I agree that the Tomcat / Spring MVC plugins could provide a more accurate way to detect the runtime dependencies. But the current implementation in this PR can be hardly met the requirement from from a performance perspective. > If a user over-references or indirectly references an unused dependency, the application itself may still work fine, but suddenly, Skywalking crashes. Well, this is a good question. IMHO, you should run dependencies check before the artifact is going to be **promoted** to the production artifactory, e.g. Nexus Repository for Maven. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
