[PR] fix(trace): append http method to tags error when using the Header ob… [skywalking-client-js]

Tue, 16 Jul 2024 19:28:35 -0700 


WHChen-Alex opened a new pull request, #131:
URL: https://github.com/apache/skywalking-client-js/pull/131

   > ### Search before asking
   > * [x]  I had searched in the 
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no 
similar issues.
   > 
   > ### Apache SkyWalking Component
   > NodeJS Client Side Agent (apache/skywalking-client-js)
   > 
   > ### What happened
   > Relevant code: 
https://github.com/apache/skywalking-client-js/blob/master/src/trace/interceptors/fetch.ts#L116-L121
   > 
   > <img alt="image" width="368" 
src="https://private-user-images.githubusercontent.com/2338946/342186559-9e6b4596-c107-48f7-a019-c0a828e48a5b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExMzI0MDYsIm5iZiI6MTcyMTEzMjEwNiwicGF0aCI6Ii8yMzM4OTQ2LzM0MjE4NjU1OS05ZTZiNDU5Ni1jMTA3LTQ4ZjctYTAxOS1jMGE4MjhlNDhhNWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTZUMTIxNTA2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NTRmZjIwNzAxODQ2YTAxZDU4ODljMmQ3MWUwODhjM2ZjODA5Y2U3OTRhNjZiYzRjMDVmOThhNDRjYjc3YjNlNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.uwVZ6lqrOQYGDpWmN5lYy0OAW-hNM9_ofVfGKElA2ug";>
   > If we call fetch with a Request object which contains headers, these 
headers will be throw error if enable skywalking-client-js.
   > 
   > ```js
   > const req = new Request("/api/projects", {
   >   headers: {
   >     "my-custom-header": "test",
   >   },
   > });
   > 
   > fetch(req);
   > ```
   > 
   > ### What you expected to happen
   > Fix error
   > 
   > ### How to reproduce
   > 
https://codesandbox.io/p/devbox/wh2zsm?file=%2Fpackage.json&migrateFrom=sjygtk
   > 
   > Open the devtools, switch to network tab, filter Fetch/XHR, open details 
for the request `/api/projects`, in Request Headers,  and switch to console tab 
, see that  error below
   
![image](https://github.com/user-attachments/assets/a14dd2fe-0aba-408d-b61e-84e64f57ff06)
   
   
![image](https://github.com/user-attachments/assets/fca3b93d-03ec-487d-ba4e-eb090f7780b2)
   
   
   
   > 
   > ### Anything else
   > _No response_
   > 
   > ### Are you willing to submit a pull request to fix on your own?
   > * [x]  Yes I am to submit a pull request on my own!
   > 
   > ### Code of Conduct
   > * [x]  I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to