This is an automated email from the ASF dual-hosted git repository.

wankai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new 39ee6026f4 BanyanDB: Zipkin Module set service as Entity for improving 
the query performance (#12474)
39ee6026f4 is described below

commit 39ee6026f4c1608b56b6686cfcf6da7d798c2588
Author: Wan Kai <[email protected]>
AuthorDate: Thu Jul 25 18:27:38 2024 +0800

    BanyanDB: Zipkin Module set service as Entity for improving the query 
performance (#12474)
---
 docs/en/changes/changes.md                                             | 1 +
 .../skywalking/oap/server/core/zipkin/ZipkinServiceSpanTraffic.java    | 1 -
 .../org/apache/skywalking/oap/server/core/zipkin/ZipkinSpanRecord.java | 3 +--
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index cf3d202063..96247d3255 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -37,6 +37,7 @@
 * Update the kubernetes HTTP latency related metrics source unit from `ns` to 
`ms`.
 * Support BanyanDB internal stream query execution tracing.
 * Fix Elasticsearch, MySQL, RabbitMQ dashboards typos and missing expressions.
+* BanyanDB: Zipkin Module set service as Entity for improving the query 
performance.
 
 #### UI
 
diff --git 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/zipkin/ZipkinServiceSpanTraffic.java
 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/zipkin/ZipkinServiceSpanTraffic.java
index 2681815a1e..a1699239bd 100644
--- 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/zipkin/ZipkinServiceSpanTraffic.java
+++ 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/zipkin/ZipkinServiceSpanTraffic.java
@@ -57,7 +57,6 @@ public class ZipkinServiceSpanTraffic extends Metrics {
     @Setter
     @Getter
     @Column(name = SPAN_NAME)
-    @BanyanDB.SeriesID(index = 1)
     private String spanName = Const.EMPTY_STRING;
 
     @Override
diff --git 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/zipkin/ZipkinSpanRecord.java
 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/zipkin/ZipkinSpanRecord.java
index 6749d47ccd..c576cb1f22 100644
--- 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/zipkin/ZipkinSpanRecord.java
+++ 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/zipkin/ZipkinSpanRecord.java
@@ -82,13 +82,11 @@ public class ZipkinSpanRecord extends Record {
     @Getter
     @Column(name = TRACE_ID)
     @SQLDatabase.AdditionalEntity(additionalTables = {ADDITIONAL_QUERY_TABLE}, 
reserveOriginalColumns = true)
-    @BanyanDB.SeriesID(index = 0)
     @ElasticSearch.Routing
     private String traceId;
     @Setter
     @Getter
     @Column(name = SPAN_ID)
-    @BanyanDB.SeriesID(index = 1)
     private String spanId;
     @Setter
     @Getter
@@ -116,6 +114,7 @@ public class ZipkinSpanRecord extends Record {
     private long timestamp;
     @Setter
     @Getter
+    @BanyanDB.SeriesID(index = 0)
     @Column(name = LOCAL_ENDPOINT_SERVICE_NAME)
     private String localEndpointServiceName;
     @Setter

Reply via email to