CodingMakeWordBetter commented on PR #712: URL: https://github.com/apache/skywalking-java/pull/712#issuecomment-2253765461
> If there is higher version has string as parameters, we could consider separating two interceptors. > > Regarding this issue, based on my personal ability, I can only consult with the official Redis to find the answer. However, I believe that the current situation is problematic. The plugin is 3. x, but it did not pass the testing for 3.15.6 and is reproducible, indicating that the plugin itself is not compatible with the version. > > That is not a surprise. It's common that newer versions are not supported. That is how iteration begins. But we are not sure about the specific version number, so it feels a bit strange to use version to split. In the worst case scenario of this code, the necessary condition is that the user has turned on the report switch, and the version is a lower version, and the content of byte [] cannot be converted into a string like 3.15.6, resulting in garbled parameters being reported. If we do not consider compatibility with older versions of redistriction, then I will only do local repairs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
