kezhenxu94 commented on code in PR #716:
URL: https://github.com/apache/skywalking-java/pull/716#discussion_r1759118672
##########
.github/actions/run/action.yml:
##########
@@ -47,6 +47,15 @@ runs:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-agent-test-run-${{ hashFiles('**/pom.xml')
}}
restore-keys: ${{ runner.os }}-maven-agent-test-run-
+ - name: Install docker-compose
+ shell: bash
+ if: runner.os != 'Windows'
+ run: |
+ if ! command docker-compose 2>&1 > /dev/null; then
+ echo "Installing docker-compose"
+ sudo curl -L
"https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname
-s)-$(uname -m)" -o /usr/local/bin/docker-compose
+ sudo chmod +x /usr/local/bin/docker-compose
+ fi
Review Comment:
This is not a good choice, we did this because our infra e2e uses the
docker-compose in third party SDK (testcontainers), that we cannot easily fix.
Please fix as
https://github.com/apache/skywalking-java/pull/716#issuecomment-2349282689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
