Re: [PR] feat:add support goframe v2 [skywalking-go]

Thu, 19 Sep 2024 03:47:37 -0700 


huicunjun commented on PR #203:
URL: https://github.com/apache/skywalking-go/pull/203#issuecomment-2360647843

   > > All codes merged must pass lint check. so, all fails are related to your 
codes.
   > 
   > 
![image](https://private-user-images.githubusercontent.com/26144786/368954422-ac6644b4-f16e-4d77-8b32-57e520e0ca07.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjY3NDMwMjYsIm5iZiI6MTcyNjc0MjcyNiwicGF0aCI6Ii8yNjE0NDc4Ni8zNjg5NTQ0MjItYWM2NjQ0YjQtZjE2ZS00ZDc3LThiMzItNTdlNTIwZTBjYTA3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTE5VDEwNDUyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIwZDg3MmEzMDE3Y2NmMjBhOTAwYjEwOGIwYzMzOGFhY2JkZWE4YzgzM2YzYjhlNzViZDFiOTg3MzNlMmJiMjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Jaa3qTWBYFTtSjjAdK3Qu5Yz5sy9DJEcoJJ1rS2YE0w)
 
![image](https://private-user-images.githubusercontent.com/26144786/368954701-2e0394a2-6bca-4290-8267-517ba0480052.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJp
 
c3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjY3NDMwMjYsIm5iZiI6MTcyNjc0MjcyNiwicGF0aCI6Ii8yNjE0NDc4Ni8zNjg5NTQ3MDEtMmUwMzk0YTItNmJjYS00MjkwLTgyNjctNTE3YmEwNDgwMDUyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTE5VDEwNDUyNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5MzVmZjk4MGIwZTMwMDNkZjgwODkwMGE2NTM4Yzc2M2FmMjg2NWNhYWUyMDVjZDUzNDdhM2FkYzIzMDg5MjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QtOCdC_goJwX2nebYPgSAbgtepl_PLuydNbi-3LzPZA)
   > 
   > this code is fork The original project ，Can I modify it？ I want to add 
"//nolint " comment to these failed files
   
   
   I think if I make changes to these, the original author @mrproliu  won't 
approve them for me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to