wu-sheng commented on a change in pull request #3475: Add feature to control
the maximum agent log files
URL: https://github.com/apache/skywalking/pull/3475#discussion_r325057533
##########
File path:
apm-sniffer/apm-agent-core/src/test/java/org/apache/skywalking/apm/agent/core/logging/core/FileWriterTest.java
##########
@@ -50,6 +54,27 @@ public void testWriteFile() throws InterruptedException {
Thread.sleep(10000L);
}
+ @Test
+ public void testDeleteWhenRollover() throws InterruptedException {
Review comment:
@kezhenxu94 Last time your told me, file OPs in CI are dangerous, which
could trigger CI unstable, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
