wu-sheng commented on code in PR #361: URL: https://github.com/apache/skywalking-python/pull/361#discussion_r1837671134
########## .github/PULL_REQUEST_TEMPLATE: ########## @@ -13,7 +13,7 @@ <!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ==== ### Improve the performance of <class or module or ...> -- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java) +- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/9e36eaccb4b4703101d83f920c3c58638e739298/oap-server/microbench/src/main/java/org/apache/skywalking/oap/server/microbench/library/datacarrier/LinkedArrayBenchmark.java) Review Comment: I think we just need to point to master branch? You could update this after this PR get accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
