wu-sheng commented on code in PR #12936:
URL: https://github.com/apache/skywalking/pull/12936#discussion_r1905513007
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBStorageProvider.java:
##########
@@ -209,7 +209,10 @@ public void start() throws ServiceNotProvidedException,
ModuleStartException {
BanyandbCommon.Metadata.newBuilder()
.setName(
BanyanDBUITemplateManagementDAO.GROUP))
-
.setCatalog(BanyandbCommon.Catalog.CATALOG_UNSPECIFIED)
+
.setCatalog(BanyandbCommon.Catalog.CATALOG_PROPERTY)
+
.setResourceOpts(BanyandbCommon.ResourceOpts.newBuilder()
+
.setShardNum(1)
Review Comment:
fyi @wankai123 We should be fine to keep shard as 1 for property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
