wankai123 commented on code in PR #13123:
URL: https://github.com/apache/skywalking/pull/13123#discussion_r2004657104
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBIndexInstaller.java:
##########
@@ -240,18 +259,49 @@ private ResourceExist
checkResourceExistence(MetadataRegistry.SchemaMetadata met
IntervalRule.Unit.UNIT_DAY)
.setNum(
metadata.getTtlDays())));
+ BanyandbCommon.ResourceOpts.Builder optsBuilder =
BanyandbCommon.ResourceOpts.newBuilder().setShardNum(metadata.getShard());
Review Comment:
Where to define the Property‘s Shard_Num?
And I think the above codes can be removed?
```java
.setResourceOpts(BanyandbCommon.ResourceOpts.newBuilder()
.setShardNum(metadata.getShard())
.setSegmentInterval(
IntervalRule.newBuilder()
.setUnit(
IntervalRule.Unit.UNIT_DAY)
.setNum(
metadata.getSegmentIntervalDays()))
.setTtl(
IntervalRule.newBuilder()
.setUnit(
IntervalRule.Unit.UNIT_DAY)
.setNum(
metadata.getTtlDays())));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
