hanahmily commented on code in PR #622:
URL:
https://github.com/apache/skywalking-banyandb/pull/622#discussion_r2005671789
##########
banyand/backup/backup.go:
##########
@@ -196,8 +160,7 @@ func newFS(dest string) (remote.FS, error) {
case "file":
return local.NewFS(u.Path)
case "s3":
- return aws.NewFS()
-
+ return aws.NewFS(dest)
Review Comment:
You should use `u.Path` which is the result of `url.Parse(dest)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
