Tsukilc commented on code in PR #622:
URL:
https://github.com/apache/skywalking-banyandb/pull/622#discussion_r2005727993
##########
banyand/backup/backup.go:
##########
@@ -196,8 +160,7 @@ func newFS(dest string) (remote.FS, error) {
case "file":
return local.NewFS(u.Path)
case "s3":
- return aws.NewFS()
-
+ return aws.NewFS(dest)
Review Comment:
ok! I fix it in
[062b68a](https://github.com/apache/skywalking-banyandb/pull/622/commits/062b68a57bcd9d39436b6652156a144c6897949e)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
