hanahmily commented on code in PR #654:
URL:
https://github.com/apache/skywalking-banyandb/pull/654#discussion_r2054105290
##########
banyand/metadata/embeddedserver/server.go:
##########
@@ -48,6 +51,9 @@ func (s *server) Role() databasev1.Role {
func (s *server) FlagSet() *run.FlagSet {
fs := run.NewFlagSet("metadata")
fs.StringVar(&s.rootDir, "metadata-root-path", "/tmp", "the root path
of metadata")
+ fs.StringVar(&s.autoCompactionMode, "etcd-auto-compaction-mode",
"periodic", "auto compaction mode")
+ fs.StringVar(&s.autoCompactionRetention,
"etcd-auto-compaction-retention", "1h", "auto compaction retention")
+ fs.Int64Var(&s.quotaBackendBytes, "etcd-quota-backend-bytes",
2*1024*1024, "quota for backend storage, unit")
Review Comment:
The size is too small, which caused the end-to-end test to fail. You should
use `run.Bytes` to set this flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
