zJiaJun commented on code in PR #224:
URL: https://github.com/apache/skywalking-go/pull/224#discussion_r2084745892
##########
.github/workflows/plugin-tests.yaml:
##########
@@ -106,6 +106,7 @@ jobs:
- goframe
- so11y
- cross-goroutine
+ - kafka-reporter
Review Comment:
@wu-sheng @mrproliu
I've created a new e2e test case (`test/e2e-v2/cases/go/kafka-reporter`) in
the main skywalking repository to verify the Kafka reporter functionality
introduced in this PR #224 1.
This test uses the standard service test
application(`test/e2e-v2/cases/go/service`) `SW_AGENT_REPORTER_TYPE=kafka` and
expected (`test/e2e-v2/cases/go/expected`). It passes locally.
```
SUCCESS verified case[swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql metrics exec
--expression=meter_sw_go_tracing_context_execution_time_percentile
--instance-name=$( \
swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql instance list
--service-name=go-service | yq e '.[0].name' - ) \
--service-name=go-service
]
SUMMARY 31 passed
0 failed
0 skipped
INFO verify part finished successfully
INFO deleting docker compose cluster...
time="2025-05-12T20:21:28+08:00" level=warning
msg="/Users/zhujiajun/projects/IdeaProjects/github/skywalking/test/e2e-v2/cases/go/kafka-reporter/docker-compose.yml:
the attribute `version` is obsolete, it will be ignored, please remove it to
avoid potential confusion"
Container skywalking_e2e-consumer-1 Stopping
Container skywalking_e2e-banyandb-1 Stopping
Container skywalking_e2e-consumer-1 Stopped
Container skywalking_e2e-consumer-1 Removing
......
Network skywalking_e2e_e2e Removing
Network skywalking_e2e_e2e Removed
INFO cleanup part finished successfully
```
My question is about running this test correctly in the GitHub Actions CI of
the main skywalking repository before PR #224 is merged into skywalking-go.
The current Go E2E test setup seems to rely on the `SW_AGENT_GO_COMMIT`
environment variable to pull a pre-built skywalking-go base image from ghcr.io
(e.g., FROM
`ghcr.io/apache/skywalking-go/skywalking-go:${SW_AGENT_GO_COMMIT}-goX.XX `as
base in the Dockerfile).
However, since my skywalking-go PR #224 is not merged yet, there's no
official image on ghcr.io tagged with its commit hash. Simply setting
`SW_AGENT_GO_COMMIT` in the CI workflow to my PR's commit hash will cause the
Docker build to fail as it won't find the base image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
