hanahmily commented on code in PR #675:
URL:
https://github.com/apache/skywalking-banyandb/pull/675#discussion_r2106365093
##########
pkg/node/round_robin.go:
##########
@@ -231,6 +232,19 @@ func validateGroup(group *commonv1.Group) bool {
}
type key struct {
- group string
- shardID uint32
+ group string
+ shardID uint32
+ replicas uint32
+}
+
+func (k key) equal(other key) bool {
+ return k.group == other.group && k.shardID == other.shardID
Review Comment:
It has a purpose. The distribution structure has two levels: the first is
based on group and shardID, while the second uses the replica. The equal method
belongs to the first level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
