kezhenxu94 commented on code in PR #13263:
URL: https://github.com/apache/skywalking/pull/13263#discussion_r2106426183
##########
oap-server/server-query-plugin/status-query-plugin/src/main/java/org/apache/skywalking/oap/query/debug/DebuggingHTTPHandler.java:
##########
@@ -109,8 +111,12 @@ public DebuggingHTTPHandler(final ModuleManager manager,
final StatusQueryConfig
}
@Get("/debugging/config/dump")
- public String dumpConfigurations() {
- return
serverStatusService.dumpBootingConfigurations(config.getKeywords4MaskingSecretsOfConfig());
+ public String dumpConfigurations(HttpRequest request) {
+ if
("application/json".equalsIgnoreCase(request.headers().get(HttpHeaderNames.ACCEPT)))
{
Review Comment:
This is fragile, some tools/browsers/sdks might send Accept header like this
`Accept: application/json; charset=utf-8`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
