ButterBright opened a new pull request, #682:
URL: https://github.com/apache/skywalking-banyandb/pull/682
<!--
⚠️ Please make sure to read this template first, pull requests that
don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g.
<framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow
the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow
the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature,
follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature,
follow the checklist 👆 ==== -->
Benchmark results:
BenchmarkEncodeDictionary/size=1000_cardinality=10-8
52686 21749 ns/op 24434 B/op 22 allocs/op
BenchmarkEncodeDictionary/size=10000_cardinality=100-8
3420 337781 ns/op 455111 B/op 35 allocs/op
BenchmarkEncodeDictionary/size=100000_cardinality=1000-8
592 2034122 ns/op 4905648 B/op 57 allocs/op
BenchmarkDncodeDictionary/size=1000_cardinality=10-8
60454 18299 ns/op 35563 B/op 45 allocs/op
BenchmarkDncodeDictionary/size=10000_cardinality=100-8
4284 275116 ns/op 526746 B/op 156 allocs/op
BenchmarkDncodeDictionary/size=100000_cardinality=1000-8
645 1891043 ns/op 6240652 B/op 1095 allocs/op
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Fixes apache/skywalking#13272.
- [ ] Update the [`CHANGES`
log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
