Copilot commented on code in PR #670:
URL:
https://github.com/apache/skywalking-banyandb/pull/670#discussion_r2163842952
##########
banyand/stream/query.go:
##########
@@ -216,7 +216,8 @@ func (s *stream) processSegmentsAndBuildFilters(
}
var filter, filterTS posting.List
Review Comment:
[nitpick] Consider adding a comment explaining why the cache slice return is
intentionally ignored here to avoid confusion.
```suggestion
var filter, filterTS posting.List
// The second return value of Tables() is ignored here as it is
not needed for the current logic.
```
##########
banyand/measure/service.go:
##########
@@ -121,6 +128,15 @@ func (s *service) Validate() error {
if s.maxDiskUsagePercent > 100 {
return errors.New("measure-max-disk-usage-percen must be less
than or equal to 100")
Review Comment:
Fix typo in the error message: change "percen" to "percent" for consistency
with the flag name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
