hanahmily commented on code in PR #686:
URL:
https://github.com/apache/skywalking-banyandb/pull/686#discussion_r2167876837
##########
banyand/liaison/grpc/property.go:
##########
@@ -405,11 +411,62 @@ func (ps *propertyServer) Query(ctx context.Context, req
*propertyv1.QueryReques
return &propertyv1.QueryResponse{Properties: properties, Trace: trace},
nil
}
+func (ps *propertyServer) repairPropertyIfNeed(ctx context.Context, entity
string, p *propertyWithCount, groups map[string]*commonv1.Group) error {
Review Comment:
The `repairPropertyIfNeed` function should consider limiting the number of
concurrent repair tasks to avoid overwhelming the data nodes with excessive
repair traffic. I suggest introducing a limit-size async-queue for repair
tasks.
When adding a new repair task to the queue, please also check for duplicates
by comparing the entity and ModRevision to prevent redundant repairs for the
same property version.
This would help ensure the system remains stable under heavy load and avoids
unnecessary duplicate repair operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
