mrproliu commented on code in PR #111:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/111#discussion_r2232445603
##########
profile/Profile.proto:
##########
@@ -80,3 +81,15 @@ message ProfileTaskFinishReport {
// profile task
string taskId = 3;
}
+
+// profile for go agent
+message GoProfileData{
+ string taskId = 1;
+ string traceId=2;
Review Comment:
Each trace profiling data should related to the trace segment id rather than
trace id. You should align it with the query protocol:
https://github.com/apache/skywalking-query-protocol/blob/master/profile.graphqls#L160
##########
profile/Profile.proto:
##########
@@ -80,3 +81,15 @@ message ProfileTaskFinishReport {
// profile task
string taskId = 3;
}
+
+// profile for go agent
+message GoProfileData{
+ string taskId = 1;
+ string traceId=2;
+ string endPointName=3;
+ int64 minDurationThreshold=4;
Review Comment:
It should be config when getting a profiling task, why need to report it
when uploading data?
##########
profile/Profile.proto:
##########
@@ -80,3 +81,15 @@ message ProfileTaskFinishReport {
// profile task
string taskId = 3;
}
+
+// profile for go agent
+message GoProfileData{
+ string taskId = 1;
+ string traceId=2;
+ string endPointName=3;
Review Comment:
Why the endpoint name is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
