huicunjun commented on PR #764: URL: https://github.com/apache/skywalking-java/pull/764#issuecomment-3121302217
> I don't think you run the test scenarios locally. > > * If the changes are just targeting new class, you should just need to update existing scenarios versions. > * Please read plugin test scenarios and run the existing scenarios locally, which should cover old versions and add new versions there. > * New scenarios codes should only be considered if the grpc changed the way of business, which seem not. I am unable to add new test scenarios to the existing ones because these new classes are only available in grpc 1.60. x and 1.70. x, The testing scenario can only rely on one grpc version I have kept all the old version test scenarios -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
