huicunjun commented on code in PR #764: URL: https://github.com/apache/skywalking-java/pull/764#discussion_r2233015518
########## test/plugin/scenarios/grpc-1.60.x-1.70.x-scenario/support-version.list: ########## @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# INTERNAL: HTTP/2 error code: INTERNAL_ERROR Received Goaway occur in test cases 1.0.0 to 1.5.0 +# So these versions were not included in support-version.list. if you know what caused it, please help us. + +# Contains only the last version number of each minor version + +1.73.0 +1.63.1 Review Comment: This is the Grpc change record, which states that, [https://github.com/grpc/grpc-java/commit/050ae18e2a53019f5d199427c91e7d519686fc05](https://github.com/grpc/grpc-java/commit/050ae18e2a53019f5d199427c91e7d519686fc05) AbstractServerImplBuilder is available in versions before<=1.58.1, That's our old grpc scenario Can support up to version<=1.58.1 The newly added interception points are now adapted to 1.59.0->1.73.0 I believe there won't be any major changes to grpc in the future, To be frank, we have covered grpc 1. x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
