mrproliu commented on code in PR #112:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/112#discussion_r2249750975
##########
profile/Profile.proto:
##########
@@ -80,3 +81,17 @@ message ProfileTaskFinishReport {
// profile task
string taskId = 3;
}
+
+// profile for go agent
+message GoProfileData{
+ string taskId = 1;
+ string traceSegmentId=2;
+ // the truly profile data
+ bytes payload=3;
+ // check last part true or false
+ bool isLast = 4;
+ // Span IDs with duration greater than minDuration,only in the last chunk
+ repeated int32 spanIds=5;
Review Comment:
When do you need to use this field? Could you more explain?
##########
profile/Profile.proto:
##########
@@ -80,3 +81,17 @@ message ProfileTaskFinishReport {
// profile task
string taskId = 3;
}
+
+// profile for go agent
+message GoProfileData{
+ string taskId = 1;
+ string traceSegmentId=2;
+ // the truly profile data
+ bytes payload=3;
+ // check last part true or false
+ bool isLast = 4;
+ // Span IDs with duration greater than minDuration,only in the last chunk
+ repeated int32 spanIds=5;
+ // use to reassemble fragments
+ int32 chunkId = 6;
Review Comment:
What does this field work for? You may send the profiling data without
frequency, and sort by this field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
