Copilot commented on code in PR #704:
URL:
https://github.com/apache/skywalking-banyandb/pull/704#discussion_r2252772798
##########
test/integration/standalone/other/testdata/config.yaml:
##########
@@ -0,0 +1,5 @@
+users:
+ - username: admin
+ password: 123456
+ - username: test
+ password: 123456
Review Comment:
Using a weak password '123456' in test configuration. Even for test
purposes, consider using stronger passwords to promote good security practices.
```suggestion
password: S7r0ngP@ssw0rd!A
- username: test
password: S7r0ngP@ssw0rd!B
```
##########
test/integration/standalone/other/testdata/config.yaml:
##########
@@ -0,0 +1,5 @@
+users:
+ - username: admin
+ password: 123456
+ - username: test
+ password: 123456
Review Comment:
Using a weak password '123456' in test configuration. Even for test
purposes, consider using stronger passwords to promote good security practices.
```suggestion
password: S7r0ngP@ssw0rd!A
- username: test
password: S7r0ngP@ssw0rd!T
```
##########
bydbctl/internal/cmd/testdata/.bydbctl.yaml:
##########
@@ -0,0 +1,3 @@
+group: ""
+username: "test"
+password: "123456"
Review Comment:
Using a weak password '123456' in test configuration. Even for test
purposes, consider using stronger passwords to promote good security practices.
```suggestion
password: "T3stP@ssw0rd!2024"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
