wu-sheng commented on issue #3538: Supporting 
RequestRateLimiterGatewayFilterFactory
URL: https://github.com/apache/skywalking/pull/3538#issuecomment-536438803
 
 
   The referred demo is integratuon test, you need to read the plugin tests 
document and change the codes, then make tests passed.
   
   In open source, we need to make sure cases are checked in any further 
changes. But not just your local tests.
   Please understand, we need to make sure the whole community good, and make 
sure all upstream changes are safe and could be reverified always.
   You need to spend mire time on tests than code changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to