hanahmily commented on code in PR #723:
URL:
https://github.com/apache/skywalking-banyandb/pull/723#discussion_r2277945448
##########
banyand/measure/part_iter.go:
##########
@@ -207,7 +207,9 @@ func (pi *partIter) readPrimaryBlock(bms []blockMetadata,
mr *primaryBlockMetada
}
bmPtrs := make([]*blockMetadata, 0, len(bms))
for _, bm := range bms {
- bmPtrs = append(bmPtrs, &bm)
+ bmCopy := &blockMetadata{}
Review Comment:
@ButterBright, copying it tends to fix an issue, that is, `bm` is already
cached by another pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
