wu-sheng commented on code in PR #13420:
URL: https://github.com/apache/skywalking/pull/13420#discussion_r2278152623
##########
docs/en/setup/backend/storages/banyandb.md:
##########
@@ -62,27 +62,31 @@ global:
# The batch size for querying profile data.
profileDataQueryBatchSize:
${SW_STORAGE_BANYANDB_QUERY_PROFILE_DATA_BATCH_SIZE:100}
asyncProfilerTaskQueryMaxSize:
${SW_STORAGE_BANYANDB_ASYNC_PROFILER_TASK_QUERY_MAX_SIZE:200}
+ user: ${SW_STORAGE_BANYANDB_USER:""}
+ password: ${SW_STORAGE_BANYANDB_PASSWORD:""}
# If the BanyanDB server is configured with TLS, configure the TLS cert file
path and enable TLS connection.
sslTrustCAPath: ${SW_STORAGE_BANYANDB_SSL_TRUST_CA_PATH:""}
# Cleanup TopN rules in BanyanDB server that are not configured in the
bydb-topn.yml config.
cleanupUnusedTopNRules: ${SW_STORAGE_BANYANDB_CLEANUP_UNUSED_TOPN_RULES:true}
-
+
groups:
# The group settings of record.
- # - "ShardNum": Number of shards in the group. Shards are the basic units
of data storage in BanyanDB. Data is distributed across shards based on the
hash value of the series ID.
+ # - "shardNum": Number of shards in the group. Shards are the basic units
of data storage in BanyanDB. Data is distributed across shards based on the
hash value of the series ID.
# Refer to the [BanyanDB
Shard](https://skywalking.apache.org/docs/skywalking-banyandb/latest/concept/clustering/#52-data-sharding)
documentation for more details.
- # - "SIDays": Interval in days for creating a new segment. Segments are
time-based, allowing efficient data retention and querying. `SI` stands for
Segment Interval.
- # - "TTLDays": Time-to-live for the data in the group, in days. Data
exceeding the TTL will be deleted.
+ # - "segmentInterval": Interval in days for creating a new segment.
Segments are time-based, allowing efficient data retention and querying. `SI`
stands for Segment Interval.
+ # - "ttl": Time-to-live for the data in the group, in days. Data exceeding
the TTL will be deleted.
+ # - "replicas": Number of replicas for the group/stage. Replicas are used
for data redundancy and high availability, a value of 0 means no replicas,
while a value of 1 means one primary shard and one replica, higher values
indicate more replicas.
#
- # For more details on setting `segmentIntervalDays` and `ttlDays`, refer to
the [BanyanDB
TTL](https://skywalking.apache.org/docs/main/latest/en/banyandb/ttl)
documentation.
+ # For more details on setting `segmentInterval` and `ttl`, refer to the
[BanyanDB TTL](https://skywalking.apache.org/docs/main/latest/en/banyandb/ttl)
documentation.
# The "records" section defines settings for normal datasets not specified
in records.
- # Each dataset will be grouped under a single group named "records".
+ # Each dataset will be grouped undeer a single group named "records".
Review Comment:
```suggestion
# Each dataset will be grouped under a single group named "records".
```
##########
docs/en/setup/backend/storages/banyandb.md:
##########
@@ -62,27 +62,31 @@ global:
# The batch size for querying profile data.
profileDataQueryBatchSize:
${SW_STORAGE_BANYANDB_QUERY_PROFILE_DATA_BATCH_SIZE:100}
asyncProfilerTaskQueryMaxSize:
${SW_STORAGE_BANYANDB_ASYNC_PROFILER_TASK_QUERY_MAX_SIZE:200}
+ user: ${SW_STORAGE_BANYANDB_USER:""}
+ password: ${SW_STORAGE_BANYANDB_PASSWORD:""}
# If the BanyanDB server is configured with TLS, configure the TLS cert file
path and enable TLS connection.
sslTrustCAPath: ${SW_STORAGE_BANYANDB_SSL_TRUST_CA_PATH:""}
# Cleanup TopN rules in BanyanDB server that are not configured in the
bydb-topn.yml config.
cleanupUnusedTopNRules: ${SW_STORAGE_BANYANDB_CLEANUP_UNUSED_TOPN_RULES:true}
-
+
groups:
# The group settings of record.
- # - "ShardNum": Number of shards in the group. Shards are the basic units
of data storage in BanyanDB. Data is distributed across shards based on the
hash value of the series ID.
+ # - "shardNum": Number of shards in the group. Shards are the basic units
of data storage in BanyanDB. Data is distributed across shards based on the
hash value of the series ID.
# Refer to the [BanyanDB
Shard](https://skywalking.apache.org/docs/skywalking-banyandb/latest/concept/clustering/#52-data-sharding)
documentation for more details.
- # - "SIDays": Interval in days for creating a new segment. Segments are
time-based, allowing efficient data retention and querying. `SI` stands for
Segment Interval.
- # - "TTLDays": Time-to-live for the data in the group, in days. Data
exceeding the TTL will be deleted.
+ # - "segmentInterval": Interval in days for creating a new segment.
Segments are time-based, allowing efficient data retention and querying. `SI`
stands for Segment Interval.
+ # - "ttl": Time-to-live for the data in the group, in days. Data exceeding
the TTL will be deleted.
+ # - "replicas": Number of replicas for the group/stage. Replicas are used
for data redundancy and high availability, a value of 0 means no replicas,
while a value of 1 means one primary shard and one replica, higher values
indicate more replicas.
#
- # For more details on setting `segmentIntervalDays` and `ttlDays`, refer to
the [BanyanDB
TTL](https://skywalking.apache.org/docs/main/latest/en/banyandb/ttl)
documentation.
+ # For more details on setting `segmentInterval` and `ttl`, refer to the
[BanyanDB TTL](https://skywalking.apache.org/docs/main/latest/en/banyandb/ttl)
documentation.
# The "records" section defines settings for normal datasets not specified
in records.
- # Each dataset will be grouped under a single group named "records".
+ # Each dataset will be grouped undeer a single group named "records".
records:
# The settings for the default "hot" stage.
shardNum: ${SW_STORAGE_BANYANDB_RECORDS_SHARD_NUM:1}
segmentInterval: ${SW_STORAGE_BANYANDB_RECORDS_SI_DAYS:1}
ttl: ${SW_STORAGE_BANYANDB_RECORDS_TTL_DAYS:3}
+ replicas: ${SW_STORAGE_BANYANDB_RECORDS_REPLICAS:0}
Review Comment:
```suggestion
replicasNum: ${SW_STORAGE_BANYANDB_RECORDS_REPLICAS_NUM:0}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
