Copilot commented on code in PR #770:
URL: https://github.com/apache/skywalking-java/pull/770#discussion_r2288541267
##########
test/e2e/case/expected/traces-list.yml:
##########
@@ -13,17 +13,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+debuggingtrace: null
traces:
{{- contains .traces }}
- - segmentid: {{ notEmpty .segmentid }}
- endpointnames:
- {{- contains .endpointnames }}
- - POST:/info
- {{- end }}
- duration: {{ ge .duration 0 }}
- start: "{{ notEmpty .start}}"
- iserror: false
- traceids:
- - {{ (index .traceids 0) }}
+- segmentid: {{ notEmpty .segmentid }}
+ endpointnames:
+ - POST:/info
+ duration: {{ ge .duration 0 }}
+ start: "{{ notEmpty .start}}"
+ iserror: false
+ traceids:
+ - {{ index .traceids 0 }}
Review Comment:
The indentation change from a nested structure to a simple array item may
cause YAML parsing issues. The original format with `{{- contains
.endpointnames }}` suggests this should maintain the nested structure for
consistency.
```suggestion
- {{ index .traceids 0 }}
```
##########
test/e2e/case/expected/metrics-has-value.yml:
##########
@@ -13,9 +13,13 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-{{- contains . }}
+ {{- contains . }}
- key: {{ notEmpty .key }}
- value: {{ ge .value 0 }}
+ value:
+ value: 0
+ isemptyvalue: true
- key: {{ notEmpty .key }}
- value: {{ ge .value 1 }}
-{{- end }}
\ No newline at end of file
+ value:
+ value: {{ ge .value.value 1 }}
Review Comment:
Inconsistent template syntax. Line 19 shows `value: 0` as a literal, but
this line uses `{{ ge .value.value 1 }}` which suggests a nested structure.
This inconsistency could cause template parsing errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
