wu-sheng commented on code in PR #771:
URL: https://github.com/apache/skywalking-java/pull/771#discussion_r2290608012
##########
apm-sniffer/bootstrap-plugins/jdk-http-plugin/pom.xml:
##########
@@ -32,6 +32,8 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <!-- Reset this to the blank value to avoid using -release in JDK
compiling -->
+ <maven.compiler.release></maven.compiler.release>
Review Comment:
This is intentional. Refer to Maven doc,
> Starting with JDK 9, the javac executable can accept the --release option
to specify against which Java SE release you want to build the project. For
example, you have JDK 11 installed and used by Maven, but you want to build the
project against Java 8. The --release option ensures that the code is compiled
following the rules of the programming language of the specified release, and
that generated classes target the release **as well as the public API of that
release**. This means that, unlike the old [-source and -target
options](https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html),
the compiler will detect and generate an error when using APIs that don't
exist in previous releases of Java SE.
-
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
