mrproliu commented on code in PR #230:
URL: https://github.com/apache/skywalking-go/pull/230#discussion_r2296495955
##########
plugins/gozero/go.mod:
##########
@@ -0,0 +1,93 @@
+module github.com/apache/skywalking-go/plugins/gozero
+
+go 1.19
+
+
+require (
+ github.com/apache/skywalking-go/plugins/core
v0.0.0-20250718051351-654a5930e77d
Review Comment:
You have already using the workspace, why still need to import this?
##########
go.mod:
##########
@@ -5,16 +5,19 @@ go 1.19
require (
github.com/google/uuid v1.3.0
github.com/pkg/errors v0.9.1
+ github.com/segmentio/kafka-go v0.4.48
Review Comment:
Why there have dependency changes?
##########
plugins/gozero/rest/server_middleware_intercepter.go:
##########
@@ -0,0 +1,105 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package rest
+
+import (
+ "fmt"
+ "net/http"
+
+ "github.com/apache/skywalking-go/plugins/core/operator"
+ "github.com/apache/skywalking-go/plugins/core/tracing"
+ "github.com/zeromicro/go-zero/rest"
+)
+
+const gozeroComponent int32 = 5023
+
+type ServerMiddlewareInterceptor struct {
+}
+
+// SkyWalking middleware - 采用 go-micro 的策略：复用底层 span 而不是与其冲突
Review Comment:
Please don't add the Chinese comment in every files.
##########
go.work:
##########
@@ -2,78 +2,80 @@ go 1.19
use (
.
+ ./plugins/amqp
// define the plugins
./plugins/core
./plugins/dubbo
+ ./plugins/echov4
Review Comment:
Please don't change the original workspace, just add your project into the
correct place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
