hanahmily commented on code in PR #744:
URL:
https://github.com/apache/skywalking-banyandb/pull/744#discussion_r2312673009
##########
banyand/trace/block.go:
##########
@@ -292,7 +298,6 @@ func mustReadSpansFrom(spans [][]byte, sm *dataBlock, count
int, reader fs.Reade
if uint64(len(src)) < spanLen {
logger.Panicf("insufficient data for span: need %d
bytes, have %d", spanLen, len(src))
}
- spans[i] = spans[i][:0]
spans[i] = append(spans[i], src[:spanLen]...)
Review Comment:
It's acceptable because spans[i] is set to nil during the reset process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
