hanahmily commented on code in PR #745:
URL:
https://github.com/apache/skywalking-banyandb/pull/745#discussion_r2312914235
##########
banyand/internal/sidx/sidx.go:
##########
@@ -19,29 +19,43 @@ package sidx
import (
"context"
+ "encoding/json"
+ "fmt"
"math"
+ "path/filepath"
+ "slices"
"sort"
"sync"
"sync/atomic"
"github.com/apache/skywalking-banyandb/api/common"
modelv1
"github.com/apache/skywalking-banyandb/api/proto/banyandb/model/v1"
+ "github.com/apache/skywalking-banyandb/banyand/internal/storage"
"github.com/apache/skywalking-banyandb/banyand/protector"
+ "github.com/apache/skywalking-banyandb/pkg/encoding"
+ "github.com/apache/skywalking-banyandb/pkg/fs"
"github.com/apache/skywalking-banyandb/pkg/logger"
"github.com/apache/skywalking-banyandb/pkg/run"
"github.com/apache/skywalking-banyandb/pkg/watcher"
)
+const (
+ maxUncompressedBlockSize = 2 * 1024 * 1024
Review Comment:
```suggestion
```
The maximum size of a block is controlled by its length.
##########
banyand/internal/sidx/sidx.go:
##########
Review Comment:
Extract the flush and merge logic to independent files to make this file
tidy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
