hanahmily commented on code in PR #755:
URL:
https://github.com/apache/skywalking-banyandb/pull/755#discussion_r2324918218
##########
banyand/trace/query.go:
##########
@@ -52,6 +52,9 @@ func (t *trace) Query(ctx context.Context, tqo
model.TraceQueryOptions) (model.T
if tqo.TimeRange == nil {
return nil, errors.New("invalid query options: timeRange are
required")
}
+ if len(tqo.TraceIDs) == 0 && tqo.Order == nil {
Review Comment:
@wu-sheng @wankai123 the validation of trace ids and order is introduced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
