hanahmily commented on code in PR #761: URL: https://github.com/apache/skywalking-banyandb/pull/761#discussion_r2347615528
########## docs/ebpf-sidecar-design.md: ########## @@ -0,0 +1,605 @@ +# eBPF Sidecar Design Document + +## 1. Executive Summary + +The eBPF Sidecar Agent is a kernel-level observability component for Apache SkyWalking BanyanDB that primarily monitors **page cache miss rates** - a critical metric for database performance. High cache miss rates indicate that BanyanDB is frequently reading from disk instead of memory, directly impacting query latency and throughput. By tracking these metrics at the kernel level, we can identify performance bottlenecks and optimize storage patterns. Review Comment: There are several concerns to address: 1. We want to avoid including the eBPF runtime in the images of the data nodes. 2. The page cache monitoring agent is a process that periodically analyzes relevant metrics and exports the results through Prometheus endpoints. It is not an on-demand tool. 3. Regarding the integration of this agent with the banyand process: it may be possible, but I do not currently intend to implement it, as I do not want this code to crash the data nodes or render them unbootable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
