This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch auth
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
commit 8bd94bfedd5b3530f9a925cf3bcff841e21bc39b
Author: Gao Hongtao <hanahm...@gmail.com>
AuthorDate: Wed Sep 10 06:20:12 2025 +0000
Add lifecycle sidecar configuration options
- Introduced new parameters for lifecycle sidecar in
`values-lifecycle.yaml` and `values.yaml` to specify `progressFile` and
`reportDir`.
- Updated the StatefulSet template to conditionally include these
parameters in the lifecycle command.
- Enhanced documentation in `parameters.md` to reflect the new
configuration options.
- Updated E2E test values to include the new lifecycle sidecar parameters
for testing.
---
chart/templates/cluster_data_statefulset.yaml | 6 ++++++
chart/values-lifecycle.yaml | 6 ++++++
chart/values.yaml | 6 ++++++
doc/parameters.md | 2 ++
test/e2e/values.lifecycle.yaml | 6 ++++++
5 files changed, 26 insertions(+)
diff --git a/chart/templates/cluster_data_statefulset.yaml
b/chart/templates/cluster_data_statefulset.yaml
index 3fc3163..84aa009 100644
--- a/chart/templates/cluster_data_statefulset.yaml
+++ b/chart/templates/cluster_data_statefulset.yaml
@@ -361,6 +361,12 @@ spec:
command:
- "/lifecycle"
- "--schedule={{ $roleConfig.lifecycleSidecar.schedule }}"
+ {{- if $roleConfig.lifecycleSidecar.progressFile }}
+ - "--progress-file={{ $roleConfig.lifecycleSidecar.progressFile }}"
+ {{- end }}
+ {{- if $roleConfig.lifecycleSidecar.reportDir }}
+ - "--report-dir={{ $roleConfig.lifecycleSidecar.reportDir }}"
+ {{- end }}
{{- if $.Values.storage.data.enabled }}
volumeMounts:
{{- range $claim := $.Values.storage.data.persistentVolumeClaims }}
diff --git a/chart/values-lifecycle.yaml b/chart/values-lifecycle.yaml
index 1e1891c..2bf00a0 100644
--- a/chart/values-lifecycle.yaml
+++ b/chart/values-lifecycle.yaml
@@ -473,6 +473,12 @@ cluster:
## @param cluster.data.nodeTemplate.lifecycleSidecar.schedule Schedule
for lifecycle sidecar (cron format)
##
schedule: "@hourly"
+ ## @param cluster.data.nodeTemplate.lifecycleSidecar.progressFile
Progress file path for lifecycle sidecar
+ ##
+ progressFile: "/tmp/stream/lifecycle/progress.json"
+ ## @param cluster.data.nodeTemplate.lifecycleSidecar.reportDir Report
directory path for lifecycle sidecar
+ ##
+ reportDir: "/tmp/stream/lifecycle/reports"
## @param cluster.data.nodeTemplate.lifecycleSidecar.resources
Resources for lifecycle sidecar for data pods
##
resources: {}
diff --git a/chart/values.yaml b/chart/values.yaml
index 2d91078..46249d2 100644
--- a/chart/values.yaml
+++ b/chart/values.yaml
@@ -471,6 +471,12 @@ cluster:
## @param cluster.data.nodeTemplate.lifecycleSidecar.schedule Schedule
for lifecycle sidecar (cron format)
##
schedule: "@hourly"
+ ## @param cluster.data.nodeTemplate.lifecycleSidecar.progressFile
Progress file path for lifecycle sidecar
+ ##
+ progressFile: ""
+ ## @param cluster.data.nodeTemplate.lifecycleSidecar.reportDir Report
directory path for lifecycle sidecar
+ ##
+ reportDir: ""
## @param cluster.data.nodeTemplate.lifecycleSidecar.resources
Resources for lifecycle sidecar for data pods
##
resources: {}
diff --git a/doc/parameters.md b/doc/parameters.md
index 8eacfb0..cabce51 100644
--- a/doc/parameters.md
+++ b/doc/parameters.md
@@ -167,6 +167,8 @@ The content of this document describes the parameters that
can be configured in
| `cluster.data.nodeTemplate.backupSidecar.resources` | Resources
for backup sidecar for data pods | `{}`
|
| `cluster.data.nodeTemplate.lifecycleSidecar.enabled` | Enable
lifecycle sidecar for data pods (boolean) | `false`
|
| `cluster.data.nodeTemplate.lifecycleSidecar.schedule` | Schedule
for lifecycle sidecar (cron format) | `@hourly`
|
+| `cluster.data.nodeTemplate.lifecycleSidecar.progressFile` | Progress
file path for lifecycle sidecar | `""`
|
+| `cluster.data.nodeTemplate.lifecycleSidecar.reportDir` | Report
directory path for lifecycle sidecar | `""`
|
| `cluster.data.nodeTemplate.lifecycleSidecar.resources` | Resources
for lifecycle sidecar for data pods | `{}`
|
| `cluster.data.nodeTemplate.restoreInitContainer.enabled` | Enable
restore init container for data pods (boolean) | `false`
|
| `cluster.data.nodeTemplate.restoreInitContainer.customFlags` | Custom
flags for restore init container (e.g., S3, Azure, GCS configuration) | `[]`
|
diff --git a/test/e2e/values.lifecycle.yaml b/test/e2e/values.lifecycle.yaml
index ee56bb8..fde97e6 100644
--- a/test/e2e/values.lifecycle.yaml
+++ b/test/e2e/values.lifecycle.yaml
@@ -156,6 +156,8 @@ cluster:
lifecycleSidecar:
enabled: true
schedule: "@hourly"
+ progressFile: "/tmp/stream/lifecycle/progress.json"
+ reportDir: "/tmp/stream/lifecycle/reports"
resources: {}
restoreInitContainer:
@@ -189,10 +191,14 @@ cluster:
lifecycleSidecar:
schedule: "@daily"
enabled: true
+ progressFile: "/tmp/stream/lifecycle/progress.json"
+ reportDir: "/tmp/stream/lifecycle/reports"
warm:
lifecycleSidecar:
schedule: "@daily"
enabled: true
+ progressFile: "/tmp/stream/lifecycle/progress.json"
+ reportDir: "/tmp/stream/lifecycle/reports"
cold:
replicas: 1
