Copilot commented on code in PR #506:
URL:
https://github.com/apache/skywalking-booster-ui/pull/506#discussion_r2422364637
##########
src/views/dashboard/controls/Event.vue:
##########
@@ -65,11 +65,12 @@ limitations under the License. -->
const dashboardStore = useDashboardStore();
const collapsedState = ref(true);
const originalState = ref({ h: props.data.h });
Review Comment:
The CollapsedHeight value changed from 3 to 2, but this breaking change
affects the widget's collapsed height behavior. Consider documenting this
change or ensuring it's intentional, as it may affect existing dashboard
layouts.
```suggestion
const originalState = ref({ h: props.data.h });
// BREAKING CHANGE: CollapsedHeight was changed from 3 to 2.
// This affects the widget's collapsed height and may impact existing
dashboard layouts.
// If you rely on the previous collapsed height, update your layouts
accordingly.
```
##########
src/views/dashboard/controls/Event.vue:
##########
@@ -86,7 +87,7 @@ limitations under the License. -->
dashboardStore.activeGridItem(props.data.i);
collapsedState.value = !collapsedState.value;
if (collapsedState.value) {
- dashboardStore.setConfigs({ ...props.data, ...{ h: 3 } });
+ dashboardStore.setConfigs({ ...props.data, ...{ h: CollapsedHeight } });
Review Comment:
The CollapsedHeight value changed from 3 to 2, but this breaking change
affects the widget's collapsed height behavior. Consider documenting this
change or ensuring it's intentional, as it may affect existing dashboard
layouts.
##########
src/views/dashboard/controls/Event.vue:
##########
@@ -65,11 +65,12 @@ limitations under the License. -->
const dashboardStore = useDashboardStore();
const collapsedState = ref(true);
const originalState = ref({ h: props.data.h });
+ const CollapsedHeight = 2;
onMounted(() => {
collapsedState.value = props.data.eventDefaultCollapse === undefined ?
true : props.data.eventDefaultCollapse;
if (collapsedState.value) {
- dashboardStore.setConfigs({ ...props.data, ...{ h: 3 } }, props.data.i);
+ dashboardStore.setConfigs({ ...props.data, ...{ h: CollapsedHeight } },
props.data.i);
Review Comment:
The CollapsedHeight value changed from 3 to 2, but this breaking change
affects the widget's collapsed height behavior. Consider documenting this
change or ensuring it's intentional, as it may affect existing dashboard
layouts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
