Copilot commented on code in PR #501:
URL:
https://github.com/apache/skywalking-booster-ui/pull/501#discussion_r2389684755
##########
src/views/alarm/Header.vue:
##########
@@ -114,19 +121,21 @@ limitations under the License. -->
durationRow.value = timeFormat(val);
setDurationRow(durationRow.value);
duration.value = getDurationTime();
Review Comment:
The `changeDuration` function no longer calls `refreshAlarms({ pageNum: 1
})` after updating the duration. This means changing the time range won't
automatically update the alarms display, requiring users to manually click the
query button even for time range changes.
```suggestion
duration.value = getDurationTime();
refreshAlarms({ pageNum: 1 });
```
##########
src/views/alarm/Header.vue:
##########
@@ -114,19 +121,21 @@ limitations under the License. -->
durationRow.value = timeFormat(val);
setDurationRow(durationRow.value);
duration.value = getDurationTime();
- refreshAlarms({ pageNum: 1 });
}
function changeEntity(param: { value: string }[]) {
entity.value = param[0].value;
Review Comment:
The `changeEntity` function no longer calls `refreshAlarms({ pageNum: 1 })`
after updating the entity. This means changing the entity selection won't
automatically update the alarms display, requiring users to manually click the
query button even for entity changes.
```suggestion
entity.value = param[0].value;
refreshAlarms({ pageNum: 1 });
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
