This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 2ea44e798a BanyanDB: fix query `getInstance` by instance ID. (#13549)
2ea44e798a is described below
commit 2ea44e798a5de9939929572f47ed1acf7190ee64
Author: Wan Kai <[email protected]>
AuthorDate: Tue Oct 21 17:08:45 2025 +0800
BanyanDB: fix query `getInstance` by instance ID. (#13549)
---
docs/en/changes/changes.md | 1 +
.../storage/plugin/banyandb/measure/BanyanDBMetadataQueryDAO.java | 4 +---
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
index b71a7740aa..24a3e5b404 100644
--- a/docs/en/changes/changes.md
+++ b/docs/en/changes/changes.md
@@ -110,6 +110,7 @@
* Fix the malfunctioning alarm feature of MAL metrics due to unknown metadata
in L2 aggregate worker.
* Make MAL percentile align with OAL percentile calculation.
* Update Grafana dashboards for OAP observability.
+* BanyanDB: fix query `getInstance` by instance ID.
#### UI
diff --git
a/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBMetadataQueryDAO.java
b/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBMetadataQueryDAO.java
index 9138f7e0b4..5f7cd9fc25 100644
---
a/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBMetadataQueryDAO.java
+++
b/oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/measure/BanyanDBMetadataQueryDAO.java
@@ -144,7 +144,6 @@ public class BanyanDBMetadataQueryDAO extends
AbstractBanyanDBDAO implements IMe
@Override
public ServiceInstance getInstance(String instanceId) throws IOException {
- IDManager.ServiceInstanceID.InstanceIDDefinition id =
IDManager.ServiceInstanceID.analysisId(instanceId);
MetadataRegistry.Schema schema =
MetadataRegistry.INSTANCE.findMetricMetadata(InstanceTraffic.INDEX_NAME,
DownSampling.Minute);
MeasureQueryResponse resp = query(false, schema,
INSTANCE_TRAFFIC_TAGS,
@@ -152,8 +151,7 @@ public class BanyanDBMetadataQueryDAO extends
AbstractBanyanDBDAO implements IMe
new QueryBuilder<MeasureQuery>() {
@Override
protected void apply(MeasureQuery query) {
- query.and(eq(InstanceTraffic.SERVICE_ID,
id.getServiceId()))
- .and(eq(InstanceTraffic.NAME, id.getName()));
+ query.and(eq(ID, instanceId));
}
});
return resp.size() > 0 ? buildInstance(resp.getDataPoints().get(0),
schema) : null;