Copilot commented on code in PR #213:
URL:
https://github.com/apache/skywalking-showcase/pull/213#discussion_r2468097437
##########
deploy/platform/kubernetes/values.yaml:
##########
@@ -291,14 +289,23 @@ skywalking:
- ReadWriteOnce
storageClass: ~
volumeMode: Filesystem
- - mountTargets: [ "measure", "stream", "property" ]
+ - mountTargets: [ "trace" ]
+ nodeRole: hot
+ existingClaimName: null
+ claimName: hot-trace-data
+ size: 50Gi
+ accessModes:
+ - ReadWriteOnce
+ storageClass: null
Review Comment:
Inconsistent use of `null` vs `~` for null values. Other persistent volume
claims in this file use `~` (YAML null syntax) for storageClass (lines 260,
290, 307). Use `~` instead of `null` for consistency.
```suggestion
storageClass: ~
```
##########
deploy/platform/kubernetes/values.yaml:
##########
@@ -291,14 +289,23 @@ skywalking:
- ReadWriteOnce
storageClass: ~
volumeMode: Filesystem
- - mountTargets: [ "measure", "stream", "property" ]
+ - mountTargets: [ "trace" ]
+ nodeRole: hot
+ existingClaimName: null
+ claimName: hot-trace-data
+ size: 50Gi
+ accessModes:
+ - ReadWriteOnce
+ storageClass: null
Review Comment:
Inconsistent use of `null` vs `~` for null values. Other persistent volume
claims in this file use `~` (YAML null syntax) for storageClass (lines 260,
290, 307). Use `~` instead of `null` for consistency.
```suggestion
existingClaimName: ~
claimName: hot-trace-data
size: 50Gi
accessModes:
- ReadWriteOnce
storageClass: ~
```
##########
deploy/platform/kubernetes/Makefile:
##########
@@ -34,12 +34,13 @@ else
PVC_STORAGE_CLASS_FIELD := ,"storageClass":"$(STORAGE_CLASS_SANITIZED)"
HELM_OPTIONS := $(HELM_OPTIONS) --set
skywalking.banyandb.etcd.persistence.storageClass=$(STORAGE_CLASS_SANITIZED)
endif
-HELM_OPTIONS := $(HELM_OPTIONS) --set-json
'skywalking.banyandb.storage.liaison.persistentVolumeClaims[0]={"mountTargets":["measure","stream"],"claimName":"liaison-data","size":"10Gi","accessModes":["ReadWriteOnce"]$(PVC_STORAGE_CLASS_FIELD),"volumeMode":"Filesystem"}'
+HELM_OPTIONS := $(HELM_OPTIONS) --set-json
'skywalking.banyandb.storage.liaison.persistentVolumeClaims[0]={"mountTargets":["measure","stream","trace"],"claimName":"liaison-data","size":"10Gi","accessModes":["ReadWriteOnce"]$(PVC_STORAGE_CLASS_FIELD),"volumeMode":"Filesystem"}'
HELM_OPTIONS := $(HELM_OPTIONS) --set-json
'skywalking.banyandb.storage.data.persistentVolumeClaims[0]={"mountTargets":["stream"],"nodeRole":"hot","claimName":"hot-stream-data","size":"10Gi","accessModes":["ReadWriteOnce"]$(PVC_STORAGE_CLASS_FIELD),"volumeMode":"Filesystem"}'
HELM_OPTIONS := $(HELM_OPTIONS) --set-json
'skywalking.banyandb.storage.data.persistentVolumeClaims[1]={"mountTargets":["measure"],"nodeRole":"hot","claimName":"hot-measure-data","size":"10Gi","accessModes":["ReadWriteOnce"]$(PVC_STORAGE_CLASS_FIELD),"volumeMode":"Filesystem"}'
-HELM_OPTIONS := $(HELM_OPTIONS) --set-json
'skywalking.banyandb.storage.data.persistentVolumeClaims[2]={"mountTargets":["property"],"nodeRole":"hot","claimName":"hot-property-data","size":"2Gi","accessModes":["ReadWriteOnce"]$(PVC_STORAGE_CLASS_FIELD),"volumeMode":"Filesystem"}'
-HELM_OPTIONS := $(HELM_OPTIONS) --set-json
'skywalking.banyandb.storage.data.persistentVolumeClaims[3]={"mountTargets":["stream","measure","property"],"nodeRole":"warm","claimName":"warm-data","size":"50Gi","accessModes":["ReadWriteOnce"]$(PVC_STORAGE_CLASS_FIELD),"volumeMode":"Filesystem"}'
-HELM_OPTIONS := $(HELM_OPTIONS) --set-json
'skywalking.banyandb.storage.data.persistentVolumeClaims[4]={"mountTargets":["stream","measure","property"],"nodeRole":"cold","claimName":"cold-data","size":"100Gi","accessModes":["ReadWriteOnce"]$(PVC_STORAGE_CLASS_FIELD),"volumeMode":"Filesystem"}'
+HELM_OPTIONS := $(HELM_OPTIONS) --set-json
'skywalking.banyandb.storage.data.persistentVolumeClaims[2]={"mountTargets":["property"],"nodeRole":"hot","claimName":"hot-property-data","size":"5Gi","accessModes":["ReadWriteOnce"]$(PVC_STORAGE_CLASS_FIELD),"volumeMode":"Filesystem"}'
+HELM_OPTIONS := $(HELM_OPTIONS) --set-json
'skywalking.banyandb.storage.data.persistentVolumeClaims[3]={"mountTargets":["trace"],"nodeRole":"hot","claimName":"hot-trace-data","size":"50Gi","accessModes":["ReadWriteOnce"]$(PVC_STORAGE_CLASS_FIELD),"volumeMode":"Filesystem"}'
+HELM_OPTIONS := $(HELM_OPTIONS) --set-json
'skywalking.banyandb.storage.data.persistentVolumeClaims[4]={"mountTargets":["stream","measure","property","trace"],"nodeRole":"warm","claimName":"warm-data","size":"100Gi","accessModes":["ReadWriteOnce"]$(PVC_STORAGE_CLASS_FIELD),"volumeMode":"Filesystem"}'
Review Comment:
The warm storage size is configured as 100Gi in the Makefile but 100Gi in
values.yaml (line 304). While these match, the values.yaml file at line 304
shows 100Gi for warm storage, which is inconsistent with the 50Gi mentioned in
the PR changes summary for warm-data.
```suggestion
HELM_OPTIONS := $(HELM_OPTIONS) --set-json
'skywalking.banyandb.storage.data.persistentVolumeClaims[4]={"mountTargets":["stream","measure","property","trace"],"nodeRole":"warm","claimName":"warm-data","size":"50Gi","accessModes":["ReadWriteOnce"]$(PVC_STORAGE_CLASS_FIELD),"volumeMode":"Filesystem"}'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
