JophieQu commented on code in PR #13524:
URL: https://github.com/apache/skywalking/pull/13524#discussion_r2472528209
##########
oap-server/server-library/library-pprof-parser/src/main/java/org/apache/skywalking/oap/server/library/pprof/type/FrameTreeBuilder.java:
##########
@@ -49,24 +50,21 @@ public FrameTreeBuilder(ProfileProto.Profile profile) {
}
private FrameTree parseTree(RawFrameTree rawTree) {
- FrameTree tree = new FrameTree(getSignature(rawTree.getLocationId()),
rawTree.getTotal(), rawTree.getSelf());
+ FrameTree tree = new
FrameTree(getSignature(rawFrameTreeGetLocationId(rawTree)), rawTree.getTotal(),
rawTree.getSelf());
for (RawFrameTree rawChild : rawTree.getChildren().values()) {
FrameTree child = parseTree(rawChild);
tree.getChildren().add(child);
}
return tree;
}
+ // Small indirection to keep minimal change footprint while delegating
signature resolution
+ private long rawFrameTreeGetLocationId(RawFrameTree rawTree) {
+ return rawTree.getLocationId();
+ }
Review Comment:
hi, why do you want to add `rawFrameTreeGetLocationId` method, it seems that
there is no change here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
