Copilot commented on code in PR #13559:
URL: https://github.com/apache/skywalking/pull/13559#discussion_r2480222294
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/Service.java:
##########
@@ -86,6 +86,9 @@ public String getEntityId() {
private SideCar sideCar = new SideCar();
@Getter
@Setter
+ private String tlsMode;
+ @Getter
+ @Setter
Review Comment:
The @Getter and @Setter annotations for the `tlsMode` field should be placed
together on consecutive lines (87-88), while the annotations for the following
field should be on lines 90-91. Currently, line 90-91 contain duplicated
@Getter/@Setter annotations that appear to belong to the next field (`attr0`).
The standard pattern in this file is to place both annotations together before
each field declaration.
##########
docs/en/concepts-and-designs/scope-definitions.md:
##########
@@ -35,6 +36,7 @@ This calculates the metrics data from each request of the TCP
service.
| sideCar.internalErrorCode | The sidecar/gateway proxy internal error code.
The value is based on the implementation.
| | string |
| receivedBytes | The received bytes of the TCP traffic.
| | long |
| sentBytes | The sent bytes of the TCP traffic.
| | long |
+| tlsMode | The TLS mode of the service
| | string |
Review Comment:
The description 'The TLS mode of the service' should end with a period for
consistency with other descriptions in the table.
```suggestion
| tlsMode | The TLS mode of the service.
| | string |
```
##########
docs/en/concepts-and-designs/scope-definitions.md:
##########
@@ -6,20 +6,21 @@ Using the Aggregation Function, the requests will be grouped
by time and **Group
This calculates the metrics data from each request of the service.
-| Name | Remarks
| Group Key | Type |
-|---------------------------|---------------------------------------------------------------------------------------------------------------------------------|-----------|------------------------|
-| name | The name of the service.
| | string |
-| layer | Layer represents an abstract framework in the
computer science, such as operation system(OS_LINUX layer), Kubernetes(k8s
layer) | | enum |
-| serviceInstanceName | The name of the service instance ID.
| | string |
-| endpointName | The name of the endpoint, such as a full path of
HTTP URI.
| | string |
-| latency | The time taken by each request.
| | int |
-| status | Indicates the success or failure of the request.
| | bool(true for success) |
-| httpResponseStatusCode | The response code of the HTTP response, and if
this request is the HTTP call. E.g. 200, 404, 302
| | int |
-| rpcStatusCode | The string value of the rpc response code.
| | string |
-| type | The type of each request. Such as: Database,
HTTP, RPC, gRPC.
| | enum |
-| tags | The labels of each request. Each value is made
up by `TagKey:TagValue` in the segment.
| | `List<String>` |
-| tag | The key-value pair of span tags in the segment.
| | `Map<String, String>` |
-| sideCar.internalErrorCode | The sidecar/gateway proxy internal error code.
The value is based on the implementation.
| | string |
+| Name | Remarks
| Group Key | Type |
+|----------------------------|---------------------------------------------------------------------------------------------------------------------------------|-----------|------------------------|
+| name | The name of the service.
| | string |
+| layer | Layer represents an abstract framework in the
computer science, such as operation system(OS_LINUX layer), Kubernetes(k8s
layer) | | enum |
+| serviceInstanceName | The name of the service instance ID.
| | string |
+| endpointName | The name of the endpoint, such as a full path
of HTTP URI.
| | string |
+| latency | The time taken by each request.
| | int |
+| status | Indicates the success or failure of the
request.
| | bool(true for success) |
+| httpResponseStatusCode | The response code of the HTTP response, and if
this request is the HTTP call. E.g. 200, 404, 302
| | int |
+| rpcStatusCode | The string value of the rpc response code.
| | string |
+| type | The type of each request. Such as: Database,
HTTP, RPC, gRPC.
| | enum |
+| tags | The labels of each request. Each value is made
up by `TagKey:TagValue` in the segment.
| | `List<String>` |
+| tag | The key-value pair of span tags in the segment.
| | `Map<String, String>` |
+| sideCar.internalErrorCode | The sidecar/gateway proxy internal error code.
The value is based on the implementation.
| | string |
+| tlsMode | The TLS mode of the service
| | string |
Review Comment:
The description 'The TLS mode of the service' should end with a period for
consistency with other descriptions in the table (e.g., 'The name of the
service.' on line 11). The TCPService tlsMode description on line 39 has the
same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
