Copilot commented on code in PR #834:
URL:
https://github.com/apache/skywalking-banyandb/pull/834#discussion_r2489010219
##########
ui/src/views/Trace/index.vue:
##########
@@ -22,9 +22,10 @@
import GroupTree from '@/components/GroupTree/index.vue';
import TopNav from '@/components/TopNav/index.vue';
import { CatalogToGroupType } from '@/components/common/data';
+ import { ASIDE_WIDTH } from '../constants';
const data = reactive({
- width: '200px',
+ width: `${ASIDE_WIDTH}px`,
Review Comment:
The ASIDE_WIDTH constant is set to 280, but the original hardcoded value was
'200px'. This changes the aside menu width from 200px to 280px, which may be
unintentional. If this is intentional, it should be documented as a behavior
change. If not, ASIDE_WIDTH should be set to 200.
##########
ui/src/views/Measure/index.vue:
##########
@@ -22,9 +22,10 @@
import TopNav from '@/components/TopNav/index.vue';
import { reactive } from 'vue';
import { CatalogToGroupType } from '@/components/common/data';
+ import { ASIDE_WIDTH } from '../constants';
const data = reactive({
- width: '200px',
+ width: `${ASIDE_WIDTH}px`,
Review Comment:
The ASIDE_WIDTH constant is set to 280, but the original hardcoded value was
'200px'. This changes the aside menu width from 200px to 280px, which may be
unintentional. If this is intentional, it should be documented as a behavior
change. If not, ASIDE_WIDTH should be set to 200.
##########
ui/src/views/Property/index.vue:
##########
@@ -22,9 +22,10 @@
import GroupTree from '@/components/GroupTree/index.vue';
import TopNav from '@/components/TopNav/index.vue';
import { CatalogToGroupType } from '@/components/common/data';
+ import { ASIDE_WIDTH } from '../constants';
const data = reactive({
- width: '200px',
+ width: `${ASIDE_WIDTH}px`,
Review Comment:
The ASIDE_WIDTH constant is set to 280, but the original hardcoded value was
'200px'. This changes the aside menu width from 200px to 280px, which may be
unintentional. If this is intentional, it should be documented as a behavior
change. If not, ASIDE_WIDTH should be set to 200.
```suggestion
width: '200px',
```
##########
ui/src/views/Stream/index.vue:
##########
@@ -22,9 +22,10 @@
import GroupTree from '@/components/GroupTree/index.vue';
import TopNav from '@/components/TopNav/index.vue';
import { CatalogToGroupType } from '@/components/common/data';
+ import { ASIDE_WIDTH } from '../constants';
const data = reactive({
- width: '200px',
+ width: `${ASIDE_WIDTH}px`,
Review Comment:
The ASIDE_WIDTH constant is set to 280, but the original hardcoded value was
'200px'. This changes the aside menu width from 200px to 280px, which may be
unintentional. If this is intentional, it should be documented as a behavior
change. If not, ASIDE_WIDTH should be set to 200.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
